1136994 - Regression: Popping and clicking at the end of every sound effect

Status: NEW

(Core :: Audio/Video: Playback, defect, P3)

Description

[Luke]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150222232811

Steps to reproduce:

https://developer.mozilla.org/en-US/demos/detail/bananabread




Actual results:

After every sound effect in BananaBread, there's a popping or clicking noise. For example go to any level without bots and compare the jumping noise in Firefox to Chrome. Firefox <= 35 and Chrome sounds exactly like Sauerbraten without a pop at the end. 


Expected results:

MainThread Bisector INFO Last good revision: 464bca437658
MainThread Bisector INFO First bad revision: be076357691c
MainThread Bisector INFO Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=464bca437658&tochange=be076357691c

Comment 1

[Luke]

:kinetik
Could this be the cause?
https://hg.mozilla.org/mozilla-central/rev/b559ec64da05

Comment 2

[Matthew Gregan [:kinetik]]

ni? myself for investigation later

Comment 3

[Maire Reavy [:mreavy]]

Luke -- Is this still a problem?  Can you retest this with the latest Nightly?

Comment 4

[Luke]

Tested on a different system with SB Audigy with the same results.  FF 44.0a1 (2015-09-25) is still making a popping noise after each jump, while Chrome does not.

Comment 5

[Maire Reavy [:mreavy]]

Paul, Karl -- Can one of you take a quick look to see if this is likely to be fixed by the work we're currently doing (especially Karl's work related to gc)?  If so, let's remember to come back to verify that it's addressed once that work lands.  

If we think this is caused by something else/new, let's use this as a bug to investigate what's going on after our other perf work (e.g. convolution reverb, gc, substractive synth) is done.

Comment 6

[Karl Tomlinson (:karlt)]

I'm in the office most of this week, so don't have a win7 test machine.
On Linux dev machine, I don't hear any jumping sounds at all.
Shooting sounds have no clicks or pops.
I don't know what "without bots" means or how to get to such levels.
Chromium won't play because "texture compression is missing".

This doesn't sound like the kind of bug that would be fixed by the perf work.

Comment 7

[Paul Adenot (:padenot)]

This game is not using the Web Audio API.

Comment 8

[Maire Reavy [:mreavy]]

Hi Andre -- How important and/or time critical is this to get fixed?  Is it blocking anything important that you know of?  Thanks.

Comment 9

[Andre Vrignaud [:andre] [Seattle - PST]]

Checked with Alon — correct, not using Web Audio API, but it should still work correctly... so be good to figure out what the issue is when possible. But, not currently blocking anything, and not critical.

Comment 10

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3