1137004 - Fps-counter is cut off in a maximized window, (and it could use some right padding).

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Johan C]

Attachment: Screenshot (left: maximized window, right: normal window).

STR:
1. Set "layers.acceleration.draw-fps" to true.
2. Maximize everything!

Note:
* If unable to maximize everything, see attached screenshot. On the left the window is maximized, on the right it is not.
* Additionally, you'll note that the fps counter could some some right padding.

Comment 1

[Benoit Girard (:BenWa)]

Good first bug.

Relevant area of the code:
http://mxr.mozilla.org/mozilla-central/ident?i=DrawFPS&filter=

Let me know if you have any question.

Comment 2

[Kyle Thomas]

Attachment: bug1137004_FPSCounterCutOff.diff

I'm new to open source and this is my first attempt at a patch. Hopefully I did this right. I just modified where it was located, so it has a little left padding and is no longer cut off when maximized.

Comment 3

[Kyle Thomas]

Thank you for the review! I'm excited to be able to submit my first patch, which I'm working on right now. Could I get this bug assigned to me so I can have a record of it? I'm in an open source class and would like to show what I've done. I'll hopefully have that patch ready to check in soon!

Comment 4

[Kyle Thomas]

Attachment: bug1137004FPSCounterCutOff.patch

This has the same changes as the other one I uploaded, its just now in an actual .patch file instead of the .diff. Hopefully this is right. Again, this is my first time going through the process.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8572365 [details] [diff] [review]
bug1137004FPSCounterCutOff.patch

That's not what the checkin flag is for :)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8570778 [details] [diff] [review]
bug1137004_FPSCounterCutOff.diff

Please mark old patches as obsolete when attaching new ones.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cd2985b7a42

Comment 8

[Kyle Thomas]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #5)
> Comment on attachment 8572365 [details] [diff] [review]
> bug1137004FPSCounterCutOff.patch
> 
> That's not what the checkin flag is for :)

Oops! Sorry, like I said I'm new to this, I'm probably going to be stumbling around for a bit until I get a couple bugs under my belt :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5cd2985b7a42