1137013 - [Camera] Volume buttons in Camera preview cause app to become unresponsive when returning to Camera

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Description:
When user takes a picture in the Camera app, opening preview by tapping icon in bottom left, then pressing volume up or down on the volume rocker causes camera app to become unresponsive when user presses back button.

Taking picture when on viewfinder screen in camera app by pressing volume rocker works as intended.

Repro Steps:
1) Update a Flame to 20150225010244
2) Launch camera app
3) Take picture and tap preview icon
4) When viewing preview press up or down on volume rocker
5) Tap back button

Actual:
Camera is unresponsive when returning from image preview after using volume rocker.

Expected:
Camera does not become unresponsive.

Environmental Variables:
Device: Flame 3.0
Build ID: 20150225010244
Gaia: f6bfd854fe4746f21bc006eac145365e85f98808
Gecko: 0a8b3b67715a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 3/3, 100%
See attached: Youtube video clip & logcat
Youtube link: http://youtu.be/bFuPFpp2GmI

Comment 1

[Brogan Zumwalt [Inactive]]

Unable to test in Flame 2.2 as the volume rocker camera feature is not present in build.

Comment 2

[Wilson Page [:wilsonpage]]

We need to make sure that the .capture() call is ignored when the preview-gallery is open.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1137013 > mozilla-b2g:master

Comment 4

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 5

[:gerard-majax]

Comment on attachment 8569819 [details] [review]
pull-request (master)

I'm not a peer for this, but that does the job.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8569819 [details] [review]
pull-request (master)

LGTM

Comment 7

[Wilson Page [:wilsonpage]]

Comment on attachment 8569819 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/2c87ad718da5d99935b32ac9933b41873ecdaed5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 approval on this patch when you get a chance.

Comment 9

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 build.

Actual Results: The camera app is still responsive after returning from preview.

Environmental Variables:
Device: Flame 3.0 KK (Full Flash) (319 MB)
BuildID: 20150312010235
Gaia: 0c4e8b0b330757e261b031b7e7f326ef419c9808
Gecko: 5334d2bead3e
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 10

[Wilson Page [:wilsonpage]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)
> Please request Gaia v2.2 approval on this patch when you get a chance.

The bug this patch fixes does not exist in v2.2 as we haven't uplifted the volume-key capture feature.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This blocks a blocker. Wilson, please request Gaia v2.2 on this when you get a chance.

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1137013-v2.2 > mozilla-b2g:v2.2

Comment 13

[Wilson Page [:wilsonpage]]

Comment on attachment 8582369 [details] [review]
[gaia] wilsonpage:1137013-v2.2 > mozilla-b2g:v2.2

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Volume rocker will toggle volume and not capture
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): New feature, moderate risk.
[String changes made]: None

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/7f1dab89dcd6ecaff2d62c031481b64b100386bf

Comment 15

[Wilson Page [:wilsonpage]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #14)
> v2.2:
> https://github.com/mozilla-b2g/gaia/commit/
> 7f1dab89dcd6ecaff2d62c031481b64b100386bf

I don't think this should have been landed as it depends on bug 1133965. Also QA think this may be too risky to uplift features at this stage. I think we should backout.

Apologies if I haven't pressed the right buttons. I'm not clear how patches with dependencies should be uplifted.

Comment 16

[Wilson Page [:wilsonpage]]

Ryan can you back the v2.2 patch out please?

Comment 17

[Ryan VanderMeulen [:RyanVM]]

The approval request should have been cleared if you changed your mind about uplifting. Or a NO_UPLIFT on the whiteboard if you weren't sure yet.

v2.2: https://github.com/mozilla-b2g/gaia/commit/cf9c885e882cee2452be36154fafe24c039b8518

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Also, blocking 2.2+ status should probably be revisited.

Comment 19

[Boon]

Per comment 9 & comment 17, clear "verifyme" keyword.