Closed
Bug 1137053
Opened 9 years ago
Closed 9 years ago
Albums in grid view are not operable by screen reader
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S8 (20mar)
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access)
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
squib
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
STR: navigate to an album "button". double tap. nothing happens. This has something to do with the fact that it only gets activated after a transitionend when the album tile loses the :active pseudoclass. I guess we never get an active pseudoclass with a scripted click in the a11y API.
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Component: Gaia → Gaia::Music
Assignee | ||
Updated•9 years ago
|
Attachment #8578858 -
Flags: review?(squibblyflabbetydoo)
Comment 2•9 years ago
|
||
Comment on attachment 8578858 [details] [review] [gaia] eeejay:bug-1137053 > mozilla-b2g:master r=me with review comments addressed (see GitHub).
Attachment #8578858 -
Flags: review?(squibblyflabbetydoo) → review+
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → eitan
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/28928 Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8578858 [details] [review] [gaia] eeejay:bug-1137053 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: Users with the screen reader cannot tap on album tiles. [Testing completed]: Yes. [Risk to taking this patch] (and alternatives if risky): Low. [String changes made]: No.
Attachment #8578858 -
Flags: approval-gaia-v2.2?
Assignee | ||
Comment 5•9 years ago
|
||
I never got a chance to land this in master first because of all the tree closures. So I am parallelizing asking for v2.2.
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/8da5465145a0fa1ba29ff9382563992f9efefc59
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Attachment #8578858 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 7•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/4d0e0e40c6d6157f5a9981fccfdbaf0ce205912e
You need to log in
before you can comment on or make changes to this bug.
Description
•