Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dimi, Assigned: dimi)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
There are plenty things i would like to refactor nfcd
Here are some examples:
1.Follow coding style in 
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style
2.Remove un-used code
3.Refine debug message
Hi,

Just some advertisement! :)

For bluetoothd, I wrote libfdio. It's a light-weight shared library that implements a poll loop for file descriptors. It also supports tasks (C version of nsRunnable in Gecko) and timers.

If you are going to refactor nfcd, you might want to consider libfdio as an alternative to the current main loop.
(Assignee)

Comment 2

4 years ago
(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #1)
> Hi,
> 
> Just some advertisement! :)
> 
> For bluetoothd, I wrote libfdio. It's a light-weight shared library that
> implements a poll loop for file descriptors. It also supports tasks (C
> version of nsRunnable in Gecko) and timers.
> 
> If you are going to refactor nfcd, you might want to consider libfdio as an
> alternative to the current main loop.

Great , I will check it !
Thanks!
(Assignee)

Comment 3

4 years ago
Created attachment 8569770 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd

Hi Yoshi,
Sorry this patch is quite large, but it only change following two things:
1.Change function naming style with upper case in the beginning
2.Change function parameters naming style with "aXXX"

There are still lots of refactor i will do , but I would like to check-in this change first because it affects every files then I will not have to rebase every time when nfcd is updated
Attachment #8569770 - Flags: review?(allstars.chh)
(Assignee)

Comment 4

4 years ago
Created attachment 8569776 [details] [diff] [review]
Git diff

Attach git diff for easier review
Attachment #8569770 - Flags: review?(allstars.chh) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://github.com/mozilla-b2g/platform_system_nfcd/commit/84395037a7a04546e8ef7cb81572eb516b85562b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.