1137055 - [NFC]nfcd refactor

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Dimi Lee [:dimi]]

There are plenty things i would like to refactor nfcd
Here are some examples:
1.Follow coding style in 
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style
2.Remove un-used code
3.Refine debug message

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi,

Just some advertisement! :)

For bluetoothd, I wrote libfdio. It's a light-weight shared library that implements a poll loop for file descriptors. It also supports tasks (C version of nsRunnable in Gecko) and timers.

If you are going to refactor nfcd, you might want to consider libfdio as an alternative to the current main loop.

Comment 2

[Dimi Lee [:dimi]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #1)
> Hi,
> 
> Just some advertisement! :)
> 
> For bluetoothd, I wrote libfdio. It's a light-weight shared library that
> implements a poll loop for file descriptors. It also supports tasks (C
> version of nsRunnable in Gecko) and timers.
> 
> If you are going to refactor nfcd, you might want to consider libfdio as an
> alternative to the current main loop.

Great , I will check it !
Thanks!

Comment 3

[Dimi Lee [:dimi]]

Attachment: pull request to mozilla-b2g/platform_system_nfcd

Hi Yoshi,
Sorry this patch is quite large, but it only change following two things:
1.Change function naming style with upper case in the beginning
2.Change function parameters naming style with "aXXX"

There are still lots of refactor i will do , but I would like to check-in this change first because it affects every files then I will not have to rebase every time when nfcd is updated

Comment 4

[Dimi Lee [:dimi]]

Attachment: Git diff

Attach git diff for easier review

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://github.com/mozilla-b2g/platform_system_nfcd/commit/84395037a7a04546e8ef7cb81572eb516b85562b