1137077 - I'm seeing problems with 'appearance' add-ons in this code since Sunday 22-Feb-2015.

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[sci-fi]

Hello,

I am seeing problems when using an 'appearance' add-on since there was some code altered just-before the m-c and c-c both became 39.0a1 (it seems these commits were applied on Sunday Feb. 22 daytime Eastern while 38.0a1 was in effect).

And both apps tinderbox builds, now at 39.0a1, are still experiencing these problems when using 'appearance' add-ons.  I believe therefore the affected code got released into the beta builds etc.

A snip from a chat I had with the Zigboom Designs crew who makes the "BlackFox" and "LavaFox" etc add-ons when I first noticed this problem:

> It seems earlier today [Sunday Feb.22 2015 afternoon E.T.] we've gotten some code changes into the master/tinderbox builds that seem to conflict with some OSX system icons (I'm still using 10.6.8, long story why I can't upgrade the o.s. here).  For example we've lost the "traffic lights" in the upper-left corner (Red/Yellow/Green buttons [that OSX uses] for closing the window or shrinking it to the dock etc).  I had to disable your add-ons to get the OSX GUI icons back [in permanent fashion]. […]

I can only use his method _once_ (menu bar -> Customize) on Firefox Nightly builds, and this will not even show-up properly on Thunderbird Daily builds (where the "traffic lights" show at the extreme top-right corner only).

Then when I close a (working) FF window (OSX keeps the task alive in this case), then open a new window, suddenly the topmost full edge goes away _again_, and I cannot utilize the menubar->Customize any more to 'fix' it.

However, I discovered a way to get a window drawn completely: with no FF windows open at all, I make some other task the front-most active one, then select the Firefox/Nightly icon in the OSX Dock, this task-switching will cause a whole new "empty" window be drawn which does include the missing top pieces (I always set my FF prefs to show an empty window).

I test the tinderbox builds in order to try getting a finely-grained timeframe when the code got hosed.
So it seems the first bad build was showing this Build-ID:
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:38.0) Gecko/20100101 Firefox/38.0 ID:20150222104445 CSet: 86d2bb8bb1c9"
which I fetched from here:
<https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64/1424630685/>
Earlier builds should not be affected in this arena.

The bugzilla search facility is still way too overwhelming to me, I don't have a clue how to do a search to see if this is already an opened incident.  And likewise how to get it reported properly if not.  ;)  I think I can eliminate the add-on itself: already it is occurring on the Zigboom code as well as the "FT DeepDark" code from stefrosselli.com (whom I've also written, and I use his "TT DeepDark" code for Thunderbird).

Sorry this got kinda long, but my main paid job had been partly having to write technical reports of this nature to the "big-iron" vendors (I'm on disability now with no end in sight, and still need help in acquiring good F/OSS equipment to use here at home, still can't afford anything).

BTW Mr Anthony Hughes suggested I go ahead to file this report here.

Thanks for this opportunity.  :)

Comment 1

[Dave Townsend [:mossop]]

(In reply to sci-fi from comment #0)
> I test the tinderbox builds in order to try getting a finely-grained
> timeframe when the code got hosed.
> So it seems the first bad build was showing this Build-ID:
> "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:38.0) Gecko/20100101
> Firefox/38.0 ID:20150222104445 CSet: 86d2bb8bb1c9"
> which I fetched from here:
> <https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-
> central-macosx64/1424630685/>
> Earlier builds should not be affected in this arena.

So just to check, the build at https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64/1424628461/ doesn't show the issue?

That gives us a regression range in this set of changesets: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d1f1624d615c&tochange=86d2bb8bb1c9. There are only two real people who landed changes in that range so needinfoing them here to see if they have ideas. I'm not seeing anything obvious in those changes that might have affected it.

Comment 2

[sci-fi]

whoops

I am reviewing the subdirs under
<https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64/?C=N;O=D>

here's my "officially retested tonight" list for this bug

all latest builds up thru here are showing this bug
1424554726 - BUG
20150221133846
https://hg.mozilla.org/mozilla-central/rev/ef051b501adf

then this one and older seem to work
1424518366 - WORKS
20150221033246
https://hg.mozilla.org/mozilla-central/rev/a46af4f0db13

and so what commits show under the range
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a46af4f0db13&tochange=ef051b501adf

> Changes pushed after changeset a46af4f0db13, up to and including changeset ef051b501adf
> User
> Push date [To Local]	Changeset	Patch author — Commit message
> [e-mail]
> Sat Feb 21 21:38:24 2015 +0000	ef051b501adf	Ryan VanderMeulen — Merge fx-team to m-c. a=merge
> ← 17 merge changesets [Collapse]
> 	923580a290d1	Jordan Santell — Bug 1134082 - Fix uncaught promise exceptions in shader editor. r=vp
> 	de5f7b01ed51	Gareth Smith — Bug 1132001 - set noMailTo flag if gIO can't handle mailto: links in linux r=Dolske
> 	aae9d2200d62	Brian Grinstead — Bug 1134265 - Add async-storage for a simple key value store in devtools. r=jryans
> 	ab63972551cb	Abdelrhman Ahmed — Bug 1129106 - Load about:reader in the child process. r=margaret
> 	f2fd19c776cf	Abdelrhman Ahmed — Bug 1132925 - Pass messages to the parent process to set reader mode prefs. r=margaret
> 	4ecaac2ab5ef	dominique vincent — Bug 1126989 - Detect not readable links to pop up the zoomed view. r=kats, r=mcomella
> 	27dffa80e6dc	dominique vincent — Bug 1126866 - Fix the text size in zoomed view. r=kats
> 	0fd6c4c24dc9	Gijs Kruitbosch — Bug 1135317 - make explicit that test for changing app handlers in in-content prefs relies on in-content prefs, rs=me/test-only
> 	f617ca1020a2	Blair McBride — Bug 1123517 - [ReadingList] Implement basic sidebar that lists unread ReadingList items. r=florian
> 	cdb550540b47	Blair McBride — Bug 1123517 - Refactor sidebar code. r=florian
> 	63da271edfa5	Ian Moody — Bug 1134409 - Make "Full Screen" context-menu command use messages instead of CPOWs. r=mconley.
> 	feda67ef14b1	Ryan VanderMeulen — Merge b2g-inbound to m-c. a=merge
> 	0ff59a91d1fe	B2G Bumper Bot — Bumping manifests a=b2g-bump
> 	6178a00f875f	B2G Bumper Bot — Bumping gaia.json for 2 gaia revision(s) a=gaia-bump
> 
> ========
> 
> https://hg.mozilla.org/integration/gaia-central/rev/8cbe026f420c
> Author: Kevin Grandon <[e-mail]>
> Desc: Merge pull request #28346 from takenspc/jshint-sharedtest
> 
> Bug 1135324 - Reduce one more jshint xfail file on apps/sharedtest
> 
> ========
> 
> https://hg.mozilla.org/integration/gaia-central/rev/67855ecc5a94
> Author: Takeshi Kurosawa <[e-mail]>
> Desc: Bug 1135324 - Reduce one more jshint xfail file on apps/sharedtest
> 
> - template_test.js now passes `make hint` since jshint 2.6.0 supports `DocumentFragment`
> - Use `mocha` for .jshintrc
> 	0c4f1b444e00	Wes Kocher — Merge m-c to b2g-inbound a=merge
> 	87e8083da958	B2G Bumper Bot — Bumping manifests a=b2g-bump
> 	9faaa4fdb1b3	B2G Bumper Bot — Bumping gaia.json for 2 gaia revision(s) a=gaia-bump
> 
> ========
> 
> https://hg.mozilla.org/integration/gaia-central/rev/dc2adc630548
> Author: autolander <[e-mail]>
> Desc: Bug 798704 - merge pull request #28331 from rsajdok:bug#798704 to mozilla-b2g:master
> 
> ========
> 
> https://hg.mozilla.org/integration/gaia-central/rev/531ae5b7be6f
> Author: Robert Sajdok <[e-mail]>
> Desc: Bug 798704 - [Email] Clearing the search field by hitting the x icon in the search field should reset the search results list

if I did that right,
could you discerne from this list who then might need to be contacted as done above?

Comment 3

[:Gijs (he/him)]

This is probably a duplicate of bug 1136291. Try today's nightly to find out.

Comment 4

[sci-fi]

Hi,

I'm testing the current tip build dd6353d61993 which includes 46be8d043c5a for bug 1136291 , and it seems to retain the top part of the window that I mentioned missing when closed/reopened.  Also it seems I can select the menu-bar -> Customize option more than once.  ;)

I need to see if that'll fix Thunderbird, tho, too, so I'll await for a TB build that includes it.

Comment 5

[Alessio Placitelli [:Dexter]]

Bug 1111022 does not seem to be related.

Comment 6

[sci-fi]

Attachment: What I (still) see with Thunderbird 'appearance' add-on.

This is the current tip tinderbox build for Thunderbird shown on the attachment "ThunderbirdDailyStillHasProblemsForMeHere2.png":

> 20150226030202
> https://hg.mozilla.org/mozilla-central/rev/df3daecd381f
> https://hg.mozilla.org/comm-central/rev/d4d00354095f

The m-c code in TB should have incorporated the fix for bug 1136291 , but I'm still seeing what this attachment is demonstrating at the top.  Note the cut-off of the GUI (including the OSX part), and the wrong location for the OSX "traffic lights" up there, altho OSX seems to activate those buttons.

Also, on FF I am not getting any usable display at all for "about:plugins" now in the build I eluded to just above.

I know work is (hopefully) still active in this arena.  I just want to show what I've been trying to describe.  ;)

Comment 7

[:Gijs (he/him)]

(In reply to sci-fi from comment #6)
> Created attachment 8569925 [details]
> What I (still) see with Thunderbird 'appearance' add-on.
> 
> This is the current tip tinderbox build for Thunderbird shown on the
> attachment "ThunderbirdDailyStillHasProblemsForMeHere2.png":
> 
> > 20150226030202
> > https://hg.mozilla.org/mozilla-central/rev/df3daecd381f
> > https://hg.mozilla.org/comm-central/rev/d4d00354095f
> 
> The m-c code in TB should have incorporated the fix for bug 1136291 , but
> I'm still seeing what this attachment is demonstrating at the top.  Note the
> cut-off of the GUI (including the OSX part), and the wrong location for the
> OSX "traffic lights" up there, altho OSX seems to activate those buttons.

I don't know what's going on with Thunderbird here. Does it work normally without the custom theme?
 
> Also, on FF I am not getting any usable display at all for "about:plugins"
> now in the build I eluded to just above.

What does this mean?

Comment 8

[sci-fi]

(In reply to :Gijs Kruitbosch from comment #7)

Hello,

> I don't know what's going on with Thunderbird here. Does it work normally without the custom theme?

Yes, as I tried to explain at the top of this report: that the commits on Sunday affected both [all?] projects using the m-c tree once the changed code got built / incorporated into the respective products tinderbox runtimes.  I simply disable the TB add-on and then things seem to go back to 'normal', as I've had to do with the FF add-on.

>> Also, on FF I am not getting any usable display at all for "about:plugins" now in the build I eluded to just above.
> What does this mean?

A "blank" display is shown now, for me at least, when the (tabular) info for plugins should be displayed.  There usually is other text displayed, such as a link for the "official" plugin checker URL <https://www.mozilla.org/en-US/plugincheck/>.  At least I can manually enter that URL and get it to check my setups here, but I'm still missing the "information" type display.  (This is mainly for the [infernal] Adobe Flash plug-in. <w>)

FWIW and BTW, I use these 'appearance' add-ons to cut down on eyeball stress etc., they are not just 'toys' to me.

I hope all that makes sense, might be a rough day for me today.  ;)

Comment 9

[:Gijs (he/him)]

(In reply to sci-fi from comment #8)
> (In reply to :Gijs Kruitbosch from comment #7)
> 
> Hello,
> 
> > I don't know what's going on with Thunderbird here. Does it work normally without the custom theme?
> 
> Yes, as I tried to explain at the top of this report: that the commits on
> Sunday affected both [all?] projects using the m-c tree once the changed
> code got built / incorporated into the respective products tinderbox
> runtimes.  I simply disable the TB add-on and then things seem to go back to
> 'normal', as I've had to do with the FF add-on.

OK. I don't know anything about the Thunderbird code, so I don't know that I'd be much help there.

> >> Also, on FF I am not getting any usable display at all for "about:plugins" now in the build I eluded to just above.
> > What does this mean?
> 
> A "blank" display is shown now, for me at least, when the (tabular) info for
> plugins should be displayed.  There usually is other text displayed, such as
> a link for the "official" plugin checker URL
> <https://www.mozilla.org/en-US/plugincheck/>.  At least I can manually enter
> that URL and get it to check my setups here, but I'm still missing the
> "information" type display.  (This is mainly for the [infernal] Adobe Flash
> plug-in. <w>)

Can you post a screenshot? Also, do any errors appear in the browser console when you open either the addons manager or the plugins part of the add-ons manager? Have you tried reproducing this on a clean Firefox profile? ( https://support.mozilla.org/kb/profile-manager-create-and-remove-firefox-profiles )

Comment 10

[sci-fi]

Attachment: This is starting up FF and then is running 'about:plugins' showing stdout|stderr on my terminal, shows problems when using.

(In reply to :Gijs Kruitbosch from comment #9)

The attachment "aboutpluginsstdoutstderr.txt" is running 'about:plugins' showing the text printed thru stdout|stderr on my terminal, shows problems when using.

$ffn == /Applications/Nightly/FirefoxNightly.app/Contents/MacOS/firefox

BuildID:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:39.0) Gecko/20100101 Firefox/39.0 ID:20150226030226 CSet: df3daecd381f

As for a screenshot of this, I already said we get the regular "blank" screen, nothing to show there.  :(  I know.

I will need to do a new profile differently, I must do a mini-backup to be sure I won't lose anything (passwords, bank acct info, etc etc etc, since this is pre-beta software and I need to use the profile with 'official' builds also).  But I think the captured text I just posted should be enough.

Comment 11

[:Gijs (he/him)]

(In reply to sci-fi from comment #10)
> Created attachment 8570317 [details]
> This is starting up FF and then is running 'about:plugins' showing
> stdout|stderr on my terminal, shows problems when using.
> 
> (In reply to :Gijs Kruitbosch from comment #9)
> 
> The attachment "aboutpluginsstdoutstderr.txt" is running 'about:plugins'
> showing the text printed thru stdout|stderr on my terminal, shows problems
> when using.

OK. Georg is out; Blair, do you know more about what could be going wrong here?

> I will need to do a new profile differently, I must do a mini-backup to be
> sure I won't lose anything (passwords, bank acct info, etc etc etc, since
> this is pre-beta software and I need to use the profile with 'official'
> builds also).  But I think the captured text I just posted should be enough.

You can create a new profile that won't be affecting your existing profile. Please see the link I posted. Also, does the list of plugins in about:addons work? And/or does the list of plugins + add-ons in about:support work, and can you post it here?

Comment 12

[sci-fi]

Attachment: aboutaddonspart1of2.png

Screen capture of "about:addons" part 1 of 2.

Comment 13

[sci-fi]

Attachment: aboutaddonspart2of2.png

Screen capture of "about:addons" part 2 of 2.

Comment 14

[sci-fi]

Attachment: aboutpluginstotallyempty.png

Screen capture of "about:plugins" is totally empty in user-display area.

Comment 15

[sci-fi]

Attachment: aboutpluginscapturedpagesource.txt

Captured textual "Page Source" during "about:plugins" display.

Comment 16

[sci-fi]

Attachment: aboutsupportcopytexttoclipboardc&p.txt

Captured data during "copy text to clipboard" button on "about:support" screen.

Comment 17

[sci-fi]

Attachment: aboutsupportcopyrawdatatoclipboardc&p.txt

Captured data from "copy raw data to clipboard" button on "about:support" screen.

Comment 18

[sci-fi]

(In reply to :Gijs Kruitbosch from comment #11)


Hello,


I see that the latest m-c tinderbox build is now:
> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:39.0) Gecko/20100101 Firefox/39.0 ID:20150226184844 CSet: c7968255c1ea
so I fetched & installed it, and now using it.  Nothing seems different as far as this bug-report is concerned, tho.

about:addons - does work and does show completely AFAICT
.              but with a glitch - I have a slot in the "Plugins" section with an 'empty' name, it is marked "(disabled)" and "Ask to Activate" and colored that way, with a full set of 5 more buttons "Preferences" thru "Remove", and its "More" (sub)screen is completely empty.  I really wonder what this thing is (later I'll see if the stdout|stderr logs any messages).  FF will not save its "Never Activate" setting after I tried changing it.
.              and another glitch - "Wacom Pressure Plug-in" is marked "(disabled)" and "Ask to Activate" even tho I absolutely tried to change it also to "Never Activate" many times, but FF won't save it in that condition (I do have such a compatible unit but it is completely off-line in physical storage right now), it's the last line in this list, so I wonder what's going on there also.


about:support - looks ok with the myriad of items shown there.
.               I was able to do copy-&-paste of both the copy-raw-data and the copy-text buttons to clipboard, pasted into plain text files (with TextWrangler freeware from BareBones.com).  I'ved posted these here.


about:plugins - still produces complete 'empty' window in the user-display area (only the URL shows as "about:plugins").  I captured any "Page Source" from the "Web Developer" under "Tools" then attached it here.


BTW - I de-activated the "FT DeepDark 12.0" 'appearance' add-on by enabling the FF-provided "Default 39.0a1" add-on, and saw that none of the symptoms outlined above were changed (but for the 'look' of the affected GUI items of course) esp'ly those quirky Addons->Plugins lines.  So I strongly suspect a new profile won't help either.


About making a new profile:  I really do need to make a mini-backup first, to appease my paranoia anyway.  I can do this with the OSX Finder.app -> File -> Duplicate function using the location of the appropriate existing directory(ies) to make a copy of it & everything inside it.

This might take me a while.  Already I am wanting to zonk out (mainly from the meds, and of my symptoms being on disability).  So please put up with me, I should continue when I'm able, later.

.

Comment 19

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Makes me wonder if pluginreg.dat (the cache file used by nsPluginHost) is corrupt, or the plugin is just plain broken. And that is somehow affecting everything else in the Add-ons Manager. We try to assume providers may throw, but maybe PluginProvider isn't protected in some place somewhere.

It's also a possibility that this is just two unrelated problems.

I can't tell more without spending some time debugging this, and I have negative free time at the moment :\

Comment 20

[sci-fi]

(In reply to Blair McBride [:Unfocused] (I don't read bugmail - needinfo? me!) from comment #19)


Hello,

I did fetch the m-c tinderbox build at "ID:20150302125729 CSet: 0b3c520002ad" and am testing it -- seems the 'about:plugins' is now working.  Have not (re)tested the other 'about:*' bits as mentioned.

I'm (still) testing the builds with the mentioned 'appearance add-ons' disabled by enabling the appropriate 'Default' add-ons provided by the apps themselves.

FWIW -- I usually remove the 'pluginreg.dat' files for both Firefox/Nightly/Tinderbox builds and for Thunderbird/Daily/Tinderbox builds almost every time I clean-out their cache(s).  In fact I do a rather-thorough 'mini-reset operation' like this quite routinely, which is usually every time after I shut down ('Cmd+Q') these apps.  I know those files in particular should be rebuilt as needed upon (re)starting the apps.  (I've written a few shell-scripts to aid me in these endeavors.)

BTW I am trying to do the "new profile" thing -- I am just-now trying to wake up (from a horrible sleep), but need to wait for the various schedules this machine is doing ('cron' tasks and others) before I feel good enough to do a mini-backup as mentioned earlier above.

Another BTW -- I've chatted a bit privately with "Wayne Mery (Thunderbird QA)" about my predicaments, FWIW.  ;>

Let me get woke-up s'more etc.

Thank you(-all).

Comment 21

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Great - a new profile will be telling. (Look after yourself first though!)

Comment 22

[sci-fi]

Sorry for the lateness here, several problems (mainly personal) have cropped up.  (No, all is not well here.  But I think I can continue here for the present.)

I have recently noticed that the Daily builds won't show the 'Customize Titlebar' in the Nightly Tester Tools arsenal.  I'm needing to try doing the "copy build id to pasteboard", or fetch the relevant file from the tinderbox ftp area, to keep track of this info.

Also today I need to open another report to explain that suddenly every window is painted solid white in both Daily and Nightly here.  I think this started on April-1st on the m-c patching; I waited a day to not seem like a joke, obviously.  I'll report the bug# here after I get it opened.

Comment 23

[Andy McKay]

With Firefox 57 only supporting WebExtensions, this is no longer valid and "appearance" add-ons no longer work.