Closed Bug 1137129 Opened 5 years ago Closed 5 years ago
Play/pause all animations button is too big on retina
MozReview Request: Bug 1137129 - Fix the toggle-all-animations button size on retina screens; r=miker
39 bytes, text/x-review-board-request
Follow-up to bug 1129454. The icon inside the button is double the size it should be on retina screens.
/r/4359 - Bug 1137129 - Fix the toggle-all-animations button size on retina screens; r=miker Pull down this commit: hg pull review -r 52019702df8c7c1607e9dbbdd24cad2d610eded8
Attachment #8569775 - Flags: review?(mratcliffe)
Comment on attachment 8569775 [details] MozReview Request: bz://1137129/pbrosset https://reviewboard.mozilla.org/r/4357/#review3597 Ship It!
Attachment #8569775 - Flags: review?(mratcliffe) → review+
pushed to fx-team : https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=54d3bf38ca10
Do you think it's worth uplifting this to Developer Edition?
Comment on attachment 8569775 [details] MozReview Request: bz://1137129/pbrosset Approval Request Comment [Feature/regressing bug #]: Feature introduced in bug 1129454, which lacked proper retina-screen support. [User impact if declined]: If declined, users with retina screens using the new "animation inspector" panel in the devtools won't see the play/pause button properly (icon too big, only partly visible). [Describe test coverage new/current, TreeHerder]: CSS only, visual, change, no tests added for this. [Risks and why]: Only a background image size CSS change, no risk associated with this change. [String/UUID change made/needed]: None
Attachment #8569775 - Flags: approval-mozilla-aurora?
Attachment #8569775 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.