Closed Bug 1137155 Opened 8 years ago Closed 8 years ago

static assertion failed: Reference-counted class Icc should not have a public destructor

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(firefox39 fixed)

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: gerard-majax, Assigned: tzimmermann)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1136729 +++

 2:31.29 In file included from /home/alex/codaz/Mozilla/b2g/gecko/obj-libril-mulet/dom/icc/Unified_cpp_dom_icc0.cpp:11:0:
 2:31.29 /home/alex/codaz/Mozilla/b2g/gecko/dom/icc/Icc.cpp: In member function ‘virtual MozExternalRefCountType mozilla::dom::Icc::AddRef()’:
 2:31.29 /home/alex/codaz/Mozilla/b2g/gecko/dom/icc/Icc.cpp:50:45: error: static assertion failed: Reference-counted class Icc should not have a public destructor. Try to make this class's destructor non-public. If that is really not possible, you can whitelist this class by providing a HasDangerousPublicDestructor specialization for it.
 2:31.29  NS_IMPL_ADDREF_INHERITED(Icc, DOMEventTargetHelper)
Flags: needinfo?(htsai)
Flags: needinfo?(htsai)
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Attachment #8570455 - Flags: review?(htsai)
Comment on attachment 8570455 [details] [diff] [review]
[01] Bug 1137155: Marked destructor of |ICC| as protected

Review of attachment 8570455 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, Thomas.  r=me with comment addressed.

::: dom/icc/Icc.h
@@ +109,5 @@
>    IMPL_EVENT_HANDLER(cardstatechange)
>    IMPL_EVENT_HANDLER(stkcommand)
>    IMPL_EVENT_HANDLER(stksessionend)
>  
> +protected:

Since Icc is defined as MOZ_FINAL, it doesn’t make much sense to have "protected" destructor here. Let's use private instead.
Attachment #8570455 - Flags: review?(htsai) → review+
Changes since v1:

  - marked destructor as private
Attachment #8570455 - Attachment is obsolete: true
Attachment #8571878 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/a122fad0351c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.