Closed
Bug 1137164
Opened 10 years ago
Closed 10 years ago
Add a shebang to setup.py
Categories
(Tree Management :: Treeherder, defect, P4)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: jfrench)
Details
Attachments
(1 file)
So we can ./setup.py to save a few characters
|
Assignee | |
Comment 1•10 years ago
|
||
After slugging most of the day on another bug, I need some easy gratification :)
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
Please see above PR for status and review.
Attachment #8578432 -
Flags: review?(emorley)
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8578432 [details] [review]
treeherder-service-PR#432
lgtm - though jlal will need to confirm if the docker changes breaks anything :-)
Attachment #8578432 -
Flags: review?(emorley) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Awesome, thanks James. I'll merge then.
|
||
Comment 7•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder-service
https://github.com/mozilla/treeherder-service/commit/d10b7a8f8d4eaf467780d61e75ca36f71069866f
Bug 1137164 - Add a shebang to setup.py
https://github.com/mozilla/treeherder-service/commit/6563fb3fcc74424149d03adde47bba27d7e5d9c7
Merge pull request #432 from tojonmz/setup-shebang
Bug 1137164 - Add a shebang to setup.py
|
|
Assignee | |
Comment 8•10 years ago
|
||
Marking fixed per above merge.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 9•10 years ago
|
||
The docker build was failing with:
/bin/sh: 1: setup.py: not found
https://registry.hub.docker.com/u/treeherder/treeherder-service/build_id/43417/code/bet6s9wzf6zstfsruulluvz/
|
|
||
Comment 10•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-service
https://github.com/mozilla/treeherder-service/commit/7fda05e8771bc00c213aef818d362d471583fa2f
Bug 1137164 - Docker: Use ./setup.py since current directory not on path
The current directory isn't on the PATH, so the docker build was
failing with:
/bin/sh: 1: setup.py: not found
The bin/peep.py call was fine, but I've changed it for consistency.
|
|
Assignee | |
Comment 11•10 years ago
|
||
Cool, thanks Ed!
|
|
||
Comment 12•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-service
https://github.com/mozilla/treeherder-service/commit/1fb8829656ce868e5ae0e8e08de359494387f089
Bug 1137164 - Make setup.py executable
644->755, to fix docker build failure:
/bin/sh: 1: ./setup.py: Permission denied
|
|
Reporter | |
Comment 13•10 years ago
|
||
|
||
Updated•4 years ago
|
Component: Treeherder: Docs & Development → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•