1137175 - tighten up public interface of MiscContainer

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nathan Froyd [:froydnj]]

MiscContainer declares that it HasDangerousPublicDestructor.  This
declaration is accurate, but unnecessary, as MiscContainer doesn't use
any of the nsISupports machinery that checks
HasDangerousPublicDestructor.  So HasDangerousPublicDestructor is a nice
bit of documentation, but completely unused; let's remove it.

MiscContainer having a public destructor is a bit of a footgun, though.
Let's protect MiscContainer's destructor and make nsAttrValue a friend
class, since nsAttrValue is what controls the lifetime of MiscContainer
objects.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: tighten up public interface of MiscContainer

Just a little cleanup.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8569840 [details] [diff] [review]
tighten up public interface of MiscContainer

Review of attachment 8569840 [details] [diff] [review]:
-----------------------------------------------------------------

lovely

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26c29e931f79

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/26c29e931f79