113718 - XUL window open performance test

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Chris McAfee]

XUL window open test now spits out the raw data, average,
and minimum times to stdout so that tinderbox can pick them up
in the logs.  Can we also put these in a dialog, that stays up
for ? 5 seconds and then exits?  That would help people running
this test by hand.  Or make it an option somehow.

Tinderbox test expects this test to exit, so don't add anything
modal with an ok button :-)

Comment 1

[Chris McAfee]

over to bill law, adding pchen.

Comment 2

[John Morrison]

Attachment: sample way to do this

Let's just add functionality like the example into winopen.js/xul

Comment 3

[John Morrison]

Hmm, window.closed returns undefined even when the window has been closed.
Anyways, still works OK.

Comment 4

[John Morrison]

Attachment: like we care if the other window stays open

Duh.

Comment 5

[Bill Law]

Attachment: New and improved winopen.xul

Comment 6

[Bill Law]

Attachment: new and improved winopen.js

The new version of these files I just attached add the following features:

1. Enable passing arguments via search string on url.  Almost all the "const"
values at the top of winopen.js can be tweaked.  I also added the ability to
tweak the chrome: url for the window; e.g., by passing mozilla a -chrome
options like
"file:///D|winopen.xul?chrome=chrome://navigator/content/miniNav.xul".	This
requires setting a pref and thus requesting UniversalXPConnect privelage.

2. Adds content to the winopen.xul window to display results, this only works
if you specify "?close=0" in the search portion of the url.

3. Adds a "Try again" button so you can run the test again.

The only thing missing is input fields for the optional values so you can tweak
the parameters and rerun right from the dialog.

If you guys can check this out and ensure it works the same as it does
currently when invoked the way the tinderbox does it, then we can check this
in.  Alternatively, we could check it in as winopen2 .xul/.js.

Comment 7

[Chris McAfee]

great changes!  r=mcafee.  This makes it really easy to run this test now, thanks.

Comment 8

[John Morrison]

Yeah, this works great, including with an alternate navigator xul.

One thing: put a big fat comment in the js that says that using windows 
cmd.com (or command.com) you need to fully quote the argument to -chrome
when you are passing multiple parameters. i.e., cmd.com barfs on '&' in 
the command line, and doesn't support unix style '\' shell escapes.

Comment 9

[Bill Law]

Checked in enhancements along with changes for bug 113778.