1137238 - Toolbox is destroyed when switching between apps

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Alexandre Poirot [:ochameau]]

This is due to the toolbox-close even handling form webide.js:
  http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webide/content/webide.js#919

We end up closing the toolbox no matter which toolbox dispatched this toolbox-close event. We are racing this code when opening new toolboxes. Sometimes, we are receiving this event for the previously destroyed toolbox, *after* the new toolbox is being created. So that we end up breaking the creation of the new one.

STR are to connect to clock app, open a toolbox and then switch to main process.
It will automatically start opening the main process toolbox and fail doing it with no particular exception.

This issue may be highlighted by bug 1059308, I haven't tried to reproduce it on nightly. But the code itself looks wrong. We shouldn't _always_ close the _current_ toolbox when receiving toolbox-close. Also note that the DOM message event was useful in app manager case, it isn't in webide as we don't have nested iframes. We could just emit an event on toolbox-host of pass a listener in toolbox options.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdb5cfdfe82e

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8569937 [details] [diff] [review]
patch v1

Review of attachment 8569937 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable.

Comment 3

[Alexandre Poirot [:ochameau]]

This patch may only apply on top of bug 1059308 (which is also checkin-needed).

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/ead3ea3e566e

Comment 5

[Carsten Book [:Tomcat]]

sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=bc64e4250685 seems one of this changes caused :

https://treeherder.mozilla.org/logviewer.html#?job_id=2141984&repo=fx-team

Comment 6

[Alexandre Poirot [:ochameau]]

Was failing because of regression introduced in dependency bug 1059308.

Green try:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=cca5bb48656a

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/94bbcc8d45e6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/94bbcc8d45e6