Closed Bug 1137238 Opened 6 years ago Closed 6 years ago

Toolbox is destroyed when switching between apps

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

This is due to the toolbox-close even handling form webide.js:
  http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webide/content/webide.js#919

We end up closing the toolbox no matter which toolbox dispatched this toolbox-close event. We are racing this code when opening new toolboxes. Sometimes, we are receiving this event for the previously destroyed toolbox, *after* the new toolbox is being created. So that we end up breaking the creation of the new one.

STR are to connect to clock app, open a toolbox and then switch to main process.
It will automatically start opening the main process toolbox and fail doing it with no particular exception.

This issue may be highlighted by bug 1059308, I haven't tried to reproduce it on nightly. But the code itself looks wrong. We shouldn't _always_ close the _current_ toolbox when receiving toolbox-close. Also note that the DOM message event was useful in app manager case, it isn't in webide as we don't have nested iframes. We could just emit an event on toolbox-host of pass a listener in toolbox options.
Attachment #8569937 - Flags: review?(jryans)
Comment on attachment 8569937 [details] [diff] [review]
patch v1

Review of attachment 8569937 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable.
Attachment #8569937 - Flags: review?(jryans) → review+
This patch may only apply on top of bug 1059308 (which is also checkin-needed).
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/ead3ea3e566e
Assignee: nobody → poirot.alex
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Was failing because of regression introduced in dependency bug 1059308.

Green try:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=cca5bb48656a
Flags: needinfo?(poirot.alex)
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/94bbcc8d45e6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.