Devtools opened in tab (not in single window) shouldn't consume Ctrl+PageDown/Ctrl+PageUp

NEW
Unassigned

Status

defect
P3
normal
5 years ago
Last year

People

(Reporter: fabrizio.gotti, Unassigned)

Tracking

({regression})

35 Branch
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [btpp-backlog])

Attachments

(2 attachments)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150122214805

Steps to reproduce:

Open 2 tabs, tab A and tab B (the tabs can be empty, doesn't matter)
Go to tab A
Open its Web console (CTRL+SHIFT+I)
Select the Inspector Pane in Web console
In the Inspector pane, click on the 'Rules' tab on the right-hand side of the Inspector pane
Press CTRL+PAGE DOWN


Actual results:

Two simultaneous results:
1. Firefox switches to tab B
2. Firefox switches the Inspector Pane to the 'Calculated' tab in tab A's Web Console


Expected results:

Either
1. Firefox switches to tab B

-or-

2. Firefox switches the Inspector Pane to the 'Calculated' tab in tab A's Web Console

but not both.
Component: Untriaged → Developer Tools: Inspector
I'm not able to reproduce it with FF36 on Win 7.

Could you test with a clean profile, please.
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles
Flags: needinfo?(fabrizio.gotti)
Posted file Bug demo
I made a little video to demonstrate the problem. I press CTRL+PAGEDOWN 16 seconds in.
Flags: needinfo?(fabrizio.gotti)
I attached a little video (AVI) to demonstrate the bug, compressed with 7zip. I press CTRL+PAGEDOWN 16 seconds in. Notice how that (1) switches to next tab and (2) changes the tab in Web Console.

This should not happen.
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:39.0) Gecko/20100101 Firefox/39.0

Confirmed.

I have tested this and the same happens. Two tabs and first one has the Inspector opened and Rules tab. After pressing CTRL+PageDown, it switches to the second tab and the Inspector has the tab switched to Computed. Make sure you have NumLock turned off when testing this.
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:36.0) Gecko/20100101 Firefox/36.0

Test
a. 3 tabs open, namely a, b & c 

Result (confirmatory to Result 1)
a. Firefox switches to tab a, b & c
User Agent: Mozilla/5.0 (Windows 8.1 pro 32bit , rv:38.0.5) Gecko/20100101 Firefox/38.0.5

Confirmed bug!!

I have tested this on some 5 to 6 tabs and same happens that is pressing CTRL+PAGEDOWN in Web console (Inspector pane) switches tab from 1 to 2, 2 to 3,3 to 4 and so on
I was going to report similar bug, but it is actually the same. This bug should be titled as:
"Devtools opened in tab (not in single window) shouldn't consume Ctrl+PageDown"
Summary: CTRL+PAGEDOWN in Web console (Inspector pane) switches tab → Devtools opened in tab (not in single window) shouldn't consume Ctrl+PageDown
By the way, this is also true for CTRL+PAGEUP.
Summary: Devtools opened in tab (not in single window) shouldn't consume Ctrl+PageDown → Devtools opened in tab (not in single window) shouldn't consume Ctrl+PageDown/Ctrl+PageUp
Well, now I believe that it's 2 different bugs:
Ctrl+PageUp/PageDown to switch tabs in sidebar worked perfectly before bug 1008772
> pushlog_url:   https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=51b428be6213&tochange=c8288d0c7a15
And that was the original report... But actually my case (about selected node in markup-view) was _also_ regressed by 1008772.
I'm not changing title, because I personally think that Ctrl+PageUp/PageDown hotkeys aren't good for devtools since it's already used for switching tabs. Ctrl+Shift+[ and Ctrl+Shift+] would be better imo
So somebody has to make decision on what should be done here.
Status: UNCONFIRMED → NEW
Depends on: 1008772
Ever confirmed: true
Keywords: regression
Blocks: 1008772
No longer depends on: 1008772
I don't believe this shortcut is explicitly defined by devtools, nor wanted. The inspector sidebar tabs are using a xul tabbox element, which by default adds this behavior [1].

[1] https://hg.mozilla.org/integration/fx-team/file/ef461673c13f/toolkit/content/widgets/tabbox.xml#l171

It is possible to deactivate this by setting handleCtrlPageUpDown="false" as an attribute of the tabbox element #inspector-sidebar defined in inspector.xul [2]

[2] https://hg.mozilla.org/integration/fx-team/file/ef461673c13f/devtools/client/inspector/inspector.xul#l191

This issue actually affects all the tabbox xul elements (also found in debugger, netmonitor ...)

(FYI, devtools are progressively replacing XUL widgets by HTML widgets. This issue will be resolved when Bug 1259819 is implemented, but in the meantime of anyone wants to   

Inspector bug triage, filter on CLIMBING SHOES
Priority: -- → P3
Whiteboard: [btpp-backlog]
Helen: Today the user can cycle through tabs in the inspector sidebar using CTRL+PAGE_UP/DOWN. This is a default behavior defined for all XUL tabbox elements. If the user has several browser tabs opened, using CTRL+PAGE_UP/DOWN when focusing the inspector's sidebar will change the browser tab as well as the inspector sidebar tab.

Our options as I see it are:
1. disable the shortcut in devtools tabboxes => ctrl+pg_up/down will switch the browser tab
2. stop the event => ctrl+pg_up/down will switch the inspector tab if the focus is in the inspector tabbox

(If we go for 1. we could also define an alternate shortcut)

I don't think we documented/advertised this shortcut for the devtools? But I also don't know how many users are relying on it right now.
Flags: needinfo?(hholmes)
(In reply to Julian Descottes [:jdescottes] from comment #11)
> Helen: Today the user can cycle through tabs in the inspector sidebar using
> CTRL+PAGE_UP/DOWN. This is a default behavior defined for all XUL tabbox
> elements. If the user has several browser tabs opened, using
> CTRL+PAGE_UP/DOWN when focusing the inspector's sidebar will change the
> browser tab as well as the inspector sidebar tab.
> 
> Our options as I see it are:
> 1. disable the shortcut in devtools tabboxes => ctrl+pg_up/down will switch
> the browser tab
> 2. stop the event => ctrl+pg_up/down will switch the inspector tab if the
> focus is in the inspector tabbox
> 
> (If we go for 1. we could also define an alternate shortcut)
> 
> I don't think we documented/advertised this shortcut for the devtools? But I
> also don't know how many users are relying on it right now.

CC'ing Brian because he has a pretty good handle on a lot of the shortcuts in devtools and probably has an opinion.

Sounds like there is literally nothing we can do that won't be annoying to someone. I think that maybe the best course is to not affect the shortcut that affects more people (so, ctrl+page up/down changing tabs), but Brian, if you could weigh in that'd definitely make me more confident. (To clarify: option #1, and providing a different shortcut.)
Flags: needinfo?(hholmes) → needinfo?(bgrinstead)
I'd say let's add the handleCtrlPageUpDown="false" attribute to the sidebar tabbox.  I don't think this was ever intentionally captured and I agree with Comment 12 that more people are going to be aware of that shortcut for the browser tabs than for our tabbox.

I don't think adding a new shortcut is a requirement to fix this bug since we basically don't have one now when you consider that it's switching browser tabs.  I do think that Ctrl+Shift+[ (Comment 9) makes sense if we do want to add a new one though, since it maps nicely to Ctrl+[ which switches the toolbox tabs.
Flags: needinfo?(bgrinstead)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.