1137273 - Test Case - Add imagecompare email draft save test case

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

This test would take the screenshot of the email draft, exit, and resume email app to see whether the draft is properly saved

Comment 1

[No-Jun Park [:njpark]]

Once https://bugzilla.mozilla.org/show_bug.cgi?id=1131095 is fixed, this script should be able to verify that it does not regress.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1137273 > mozilla-b2g:master

Comment 3

[No-Jun Park [:njpark]]

Comment on attachment 8574188 [details] [review]
[gaia] npark-mozilla:1137273 > mozilla-b2g:master

I made a local copy of a app method, to embed screenshot methods in it.  I was thinking about adding an optional parameter to the app method to activate the screenshot, but i wasn't sure that it was the right approach.

One more thing, with this imagecompare script, marionette will crash 90% of the time (even after the test has completed). https://bugzilla.mozilla.org/show_bug.cgi?id=1137653

Comment 4

[No-Jun Park [:njpark]]

Which means, I shouldn't merge this even if I get r+ on review.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8574188 [details] [review]
[gaia] npark-mozilla:1137273 > mozilla-b2g:master

Run on my device. I had to restart the test multiple times to make it pass without a crash. I left a couple of comments in the code, but nothing's really blocking.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8574188 [details] [review]
[gaia] npark-mozilla:1137273 > mozilla-b2g:master

A few nits but otherwise this looks good. I have no issue with you recreating the setup method from the app object as you're still only using app object methods.

Comment 7

[No-Jun Park [:njpark]]

Comment on attachment 8574188 [details] [review]
[gaia] npark-mozilla:1137273 > mozilla-b2g:master

comments incorporated

Comment 8

[No-Jun Park [:njpark]]

Davehunt: I'll wait for the merge of https://bugzilla.mozilla.org/show_bug.cgi?id=1136122 into master, and make appropriate changes in the test script

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1137273_2ndAttempt > mozilla-b2g:master

Comment 10

[No-Jun Park [:njpark]]

Comment on attachment 8578940 [details] [review]
[gaia] npark-mozilla:1137273_2ndAttempt > mozilla-b2g:master

Hi Dave, I created a new pull request since I had trouble merging/rebasing it.  I incorporated your changes regarding the use of testvar, and nothing else is changed.

Comment 11

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8578940 [details] [review]
[gaia] npark-mozilla:1137273_2ndAttempt > mozilla-b2g:master

Just a couple of minor nits. Also, I don't see a Gaia-Try run? With the nits addressed please feel free to merge with r=me so long as the tests are passing.

Comment 12

[No-Jun Park [:njpark]]

Comment on attachment 8578940 [details] [review]
[gaia] npark-mozilla:1137273_2ndAttempt > mozilla-b2g:master

Per Dave's comment, I made changes and checked that try test doesn't show any failures from it, self r+ing it.

Comment 13

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.