1137289 - dumpsys failure during adb getTopActivity throws DMError

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

I think this is an adb variant of bug 1084473.

Testing the new Android 4.3 emulator, I infrequently encounter this error:

http://ftp.mozilla.org/pub/mozilla.org/mobile/try-builds/[e-mail]-9a7bba18541b/try-android-api-9/try_ubuntu64_vm_large_test-plain-reftest-5-bm115-tests1-linux64-build2.txt.gz

16:24:34     INFO -  REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/bugs/478614-5.html
16:24:34     INFO -  REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/bugs/478614-5.html | 432 / 704 (61%)
16:24:34     INFO -  
16:24:34     INFO -  WARNING: Unable to retrieve log file (/sdcard/tests/reftest/reftest.log) from remote device
16:24:34     INFO -  Automation Error: Exception caught while running tests
16:24:34     INFO -  Traceback (most recent call last):
16:24:34     INFO -    File "/builds/slave/test/build/tests/reftest/remotereftest.py", line 536, in main
16:24:34     INFO -      retVal = reftest.runTests(manifest, options, cmdlineArgs)
16:24:34     INFO -    File "/builds/slave/test/build/tests/reftest/runreftest.py", line 292, in runTests
16:24:34     INFO -      return self.runSerialTests(testPath, options, cmdlineArgs)
16:24:34     INFO -    File "/builds/slave/test/build/tests/reftest/runreftest.py", line 590, in runSerialTests
16:24:34     INFO -      debuggerInfo=debuggerInfo)
16:24:34     INFO -    File "/builds/slave/test/build/tests/reftest/remotereftest.py", line 434, in runApp
16:24:34     INFO -      timeout=timeout)
16:24:34     INFO -    File "/builds/slave/test/build/tests/reftest/automation.py", line 844, in runApp
16:24:34     INFO -      status = self.waitForFinish(proc, utilityPath, timeout, maxTime, startTime, debuggerInfo, symbolsPath)
16:24:34     INFO -    File "/builds/slave/test/build/tests/reftest/remoteautomation.py", line 91, in waitForFinish
16:24:34     INFO -      status = proc.wait(timeout = maxTime, noOutputTimeout = timeout)
16:24:34     INFO -    File "/builds/slave/test/build/tests/reftest/remoteautomation.py", line 350, in wait
16:24:34     INFO -      while (self.dm.getTopActivity() == self.procName):
16:24:34     INFO -    File "/builds/slave/test/build/tests/reftest/droid.py", line 159, in getTopActivity
16:24:34     INFO -      data = self.shellCheckOutput(["dumpsys", "window", "windows"])
16:24:34     INFO -    File "/builds/slave/test/build/tests/reftest/devicemanager.py", line 397, in shellCheckOutput
16:24:34     INFO -      raise DMError("Non-zero return code for command: %s (output: '%s', retval: '%s')" % (cmd, output, retval))
16:24:34     INFO -  DMError: Non-zero return code for command: ['dumpsys', 'window', 'windows'] (output: '', retval: 'None')
16:24:34     INFO -  WARNING: Error getting device information

Comment 1

[Geoff Brown [:gbrown]]

Attachment: ignore failure in adb getTopActivity

I'm using the same strategy used in bug 1084473: If dumpsys fails, return an empty string from getTopActivity. Callers of getTopActivity are usually looking for a certain activity (fennec), so the "" comparison fails, and the caller tries again later.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8569964 [details] [diff] [review]
ignore failure in adb getTopActivity

Review of attachment 8569964 [details] [diff] [review]:
-----------------------------------------------------------------

nice- so many exceptions in the world!

Comment 3

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/507a5971a1c1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/507a5971a1c1