1137307 - Bug reports are not valid HTML5 pages

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

Tons of errors are thrown by HTML5 validators about show_bug.cgi.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

- some cells have an obsolete colspan="2"
- some labels have a for="foo" attribute pointing to nowhere when the user is not allowed to edit fields
- the "deadline" id is duplicated
- custom fields are PROCESS'ed instead of INCLUDE'd, propagating their own variable values to other custom and hardcoded fields
- the defer attribute can only be used in <script> when src="foo" is also defined

Now show_bug.cgi is valid HTML5 when a power user is logged in, when a powerless user is logged in, and when the user is logged out.

Comment 2

[Frédéric Buclin]

Comment on attachment 8569981 [details] [diff] [review]
patch, v1

Wait, I found a bug in it.

Comment 3

[Frédéric Buclin]

Comment on attachment 8569981 [details] [diff] [review]
patch, v1

Ah no, the patch is correct. :)

Comment 4

[Frédéric Buclin]

Attachment: patch, v1.1

Forgot to include flag/list.html.tmpl in the patch.

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8570106 [details] [diff] [review]
patch, v1.1

Review of attachment 8570106 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: template/en/default/bug/edit.html.tmpl
@@ +289,4 @@
>              bug = bug, field = bug_fields.rep_platform,
>              no_tds = 1, value = bug.rep_platform
> +            editable = can_edit_rep_platform %]
> +        [%+ INCLUDE bug/field.html.tmpl 

remove whitespace on commit

Comment 6

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   c325240..7d0c10e  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   2ca129b..d725139  5.0 -> 5.0

Comment 7

[Frédéric Buclin]

(In reply to Frédéric Buclin from comment #1)
> - custom fields are PROCESS'ed instead of INCLUDE'd, propagating their own
> variable values to other custom and hardcoded fields

Argh, I already did this mistake in bug 768573 comment 4. I added a comment in the template to not do this mistake again. (Thanks to Selenium scripts for catching that!)

To ssh://[e-mail]/bugzilla/bugzilla.git
   d82782d..0bcbc0f  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   4cbac02..74d7fca  5.0 -> 5.0