Bug reports are not valid HTML5 pages

RESOLVED FIXED in Bugzilla 5.0

Status

()

Bugzilla
User Interface
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

Bugzilla 5.0
Bug Flags:
approval +
approval5.0 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Tons of errors are thrown by HTML5 validators about show_bug.cgi.
(Assignee)

Comment 1

3 years ago
Created attachment 8569981 [details] [diff] [review]
patch, v1

- some cells have an obsolete colspan="2"
- some labels have a for="foo" attribute pointing to nowhere when the user is not allowed to edit fields
- the "deadline" id is duplicated
- custom fields are PROCESS'ed instead of INCLUDE'd, propagating their own variable values to other custom and hardcoded fields
- the defer attribute can only be used in <script> when src="foo" is also defined

Now show_bug.cgi is valid HTML5 when a power user is logged in, when a powerless user is logged in, and when the user is logged out.
Attachment #8569981 - Flags: review?(dylan)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8569981 [details] [diff] [review]
patch, v1

Wait, I found a bug in it.
Attachment #8569981 - Flags: review?(dylan)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8569981 [details] [diff] [review]
patch, v1

Ah no, the patch is correct. :)
Attachment #8569981 - Flags: review?(dylan)
(Assignee)

Comment 4

3 years ago
Created attachment 8570106 [details] [diff] [review]
patch, v1.1

Forgot to include flag/list.html.tmpl in the patch.
Attachment #8569981 - Attachment is obsolete: true
Attachment #8569981 - Flags: review?(dylan)
Attachment #8570106 - Flags: review?(dylan)
(Assignee)

Updated

3 years ago
Attachment #8570106 - Flags: review?(dylan) → review?(dkl)
Comment on attachment 8570106 [details] [diff] [review]
patch, v1.1

Review of attachment 8570106 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: template/en/default/bug/edit.html.tmpl
@@ +289,4 @@
>              bug = bug, field = bug_fields.rep_platform,
>              no_tds = 1, value = bug.rep_platform
> +            editable = can_edit_rep_platform %]
> +        [%+ INCLUDE bug/field.html.tmpl 

remove whitespace on commit
Attachment #8570106 - Flags: review?(dkl) → review+

Updated

3 years ago
Flags: approval?
Flags: approval5.0?
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval+
(Assignee)

Comment 6

3 years ago
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   c325240..7d0c10e  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   2ca129b..d725139  5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

3 years ago
(In reply to Frédéric Buclin from comment #1)
> - custom fields are PROCESS'ed instead of INCLUDE'd, propagating their own
> variable values to other custom and hardcoded fields

Argh, I already did this mistake in bug 768573 comment 4. I added a comment in the template to not do this mistake again. (Thanks to Selenium scripts for catching that!)

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   d82782d..0bcbc0f  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   4cbac02..74d7fca  5.0 -> 5.0
You need to log in before you can comment on or make changes to this bug.