Closed Bug 1137325 Opened 9 years ago Closed 9 years ago

Remove the parent() function in xpcshell

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Remove the parent() function from xpcshell
2.01 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review 
Seems to be unused as far as I can tell from grepping our tree, and is one of the few remaining JS_GetParent callers.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8569985 [details] [diff] [review]
Remove the parent() function from xpcshell

This sounds good to me. Nobody should be using parent for anything from JS (and if they are, they should stop, now).
Attachment #8569985 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/8c6f22410bf8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.