Closed
Bug 1137374
Opened 11 years ago
Closed 11 years ago
Style guide: Media queries
Categories
(Marketplace Graveyard :: Code Quality, defect, P3)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: chuck, Unassigned)
References
Details
The style guide should include information about our usage of breakpoints and media queries.
- marketplace-core-css should ship with breakpoint variables and mixins implementing those variables to make CSS authoring easier.
- marketplace-style-guide should contain a detailed explanation for our usage of media queries.
| Reporter | ||
Comment 1•11 years ago
|
||
Opinions:
- We should never reference variables directly in our media queries. Instead, we should use block-level mixins for logical feature groups that implement the actual media queries we want to use.
- We should be doing this mobile-first. Base styles assume the smallest screen, and enhancement happen inside of media queries using min-widths without max-widths.
| Reporter | ||
Comment 2•11 years ago
|
||
Additional work on the style guide has been shelved.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•