113742 - file:/// directories use moz-icon

Status: VERIFIED FIXED

(Core :: Networking: File, defect)

Description

[Robert John Churchill]

Use moz-icon for file:/// displays

Comment 1

[Scott MacGregor]

if you do this, keep an eye out for performance regressions. moz-icon images
aren't cached (well they are cached but the url used to cache them is the url of
the document so file://test.zip and file://bar.zip are going to have different
places in the image cache).

Comment 2

[Robert John Churchill]

Attachment: Use moz-icon for icon references to file:/// URLs

Comment 3

[Robert John Churchill]

mscott: BTW, I just opened up bug # 113745 regarding moz-icon returning the wrong 
icon when using a file:/// which points to a directory. As mentioned in that bug, 
I added a specific check in the patch for THIS bug to not return moz-icon 
references for directories until that bug is fixed.  :)

Comment 4

[Bradley Baetz (:bbaetz)]

I thought I had a bug on me for this, but I can't find it ATM.

This won't affect html directory listings, which are currently explicitly
disabled (see nsDirectoryViewer.cpp, nsDirectoryViewerFactory::CreateInstance),
but which I hope to have on by the end of this week/early next week.

This doesn't affect the XUL ftp/gopher dir listings, does it?

Comment 5

[Robert John Churchill]

This change only affects file:/// URLs when displayed inside XUL.

Comment 6

[Robert John Churchill]

Attachment: Latest file system moz-icon: support

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 61222 [details] [diff] [review]
Latest file system moz-icon: support

[s]r=[e-mail]

Comment 8

[Steve Dagley]

Comment on attachment 61222 [details] [diff] [review]
Latest file system moz-icon: support

r=sdagley

Comment 9

[Robert John Churchill]

Fixed.

Comment 10

[benc]

Where would I see this?

Comment 11

[Robert John Churchill]

Type a valid file:/// URL into the browser's location bar. On Mac and Windows,
you'll see the OS's native icons.

Comment 12

[benc]

VERIFIED:
Mozilla 0.9.8, Mac OS 9+X, Win 98.