1137455 - Error: TypeError: this.mDeferred is null in gdataRequest.jsm

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[Kent James (:rkent)]

Error console, repeated many times:

Error: TypeError: this.mDeferred is null
Source File: resource://gdata-provider/modules/gdataRequest.jsm
Line: 244

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Any other errors, maybe the one from bug 1101175 ? With calendar.debug.log and calendar.debug.log.verbose enabled, what messages immediately preceed that error?

Comment 2

[Geoff Lankow (:darktrojan)]

I get this too, although not very often. There's one instance on my console now, with no other messages in the 6 minutes before it.

I also noticed that the non-all-day events on my Google calendar are now missing. If I restart Thunderbird, the all-day events will disappear too.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: error.log

This bug happened to me again (might be something different from my previous comment), and I managed to get the log from this calendar refresh and the two before it. That might help figure out why 401s are occurring in the first place.

(The error in the last line occurred 7 times, it just doesn't show up like that when I cut and paste.)

Comment 4

[Geoff Lankow (:darktrojan)]

> 00:41:25.699 [calGoogleSession] Token will expire in 0 seconds, refreshing

Perhaps we shouldn't try to reuse a token the very second it expires.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1137455-1.diff

Fairly certain that here's the problem. Request fails, authError. Re-auth. Request succeeds, succeed() resolves the promise. Next function in promise chain from original request calls succeed() again.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8574259 [details] [diff] [review]
1137455-1.diff

Review of attachment 8574259 [details] [diff] [review]:
-----------------------------------------------------------------

Indeed, this might actually fix it. Can you set a commit message and set checkin-needed? I'll see that this gets to be part of 1.0.5

Comment 7

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/43811e5e942c

(oops, forgot the reviewer in the commit message)