1137456 - Make the "clear all" button less prominent than the "save" button

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: Screenshot from 2015-02-26 13:39:36.png

When starring oranges, the "clear all" button is more prominent than the "save" button, encouraging the user to undo all of the work they've just done. See attached screenshot. (By "more prominent", I guess I mean it's above it, so if you're scanning top-to-buttom to find a button to press, that's the one you encounter first.)

Comment 1

[Jonathan French (:jfrench)]

Indeed, certainly we could reverse their order with Save on top, if Sheriff's are in agreement. Btw. we have an easy shortcut for Save, which is Ctrl+Enter. All the shortcuts are listed on the Help page available off the "?" icon in the top navbar.

As part of our overall UI declutter goals, we could consider removing the adjacent "-" and "file" icons also.

Comment 2

[Jonathan French (:jfrench)]

Soliciting Ed and the sheriffs if they have strong opinions either way on inverting the order of the Clear All and Save buttons.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'd say muscle memory at this point means I'd be clicking "clear all" more often after switching them. Could we just move "clear all" into the dropdown next to "save"?

Comment 4

[Jonathan French (:jfrench)]

(In reply to Wes Kocher (:KWierso) from comment #3)
> Could we just move "clear all" into the dropdown next to "save"?

My gut feel is users who aren't precise within that drop down might then be at greater risk of clearing-all while saving-classification-only, etc, than even the current layout.

I agree with Wes, I am hesitant to re-arrange UI particularly if we haven't had major push back on the current layout during heavy use the past 3/4 of a year.

Comment 5

[Ed Morley [:emorley]]

Happy to defer to the sheriffs on this :-)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I think moving it into the dropdown makes sense. FWIW, I don't think I've ever used the alternate save options in the current dropdown.

Comment 7

[Jonathan French (:jfrench)]

Cool, thanks guys. This probably isn't too gratifying as a gfb, so I'll just do it.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #6)
> FWIW, I don't think I've ever used the alternate save options in the current dropdown.

Same here.

Comment 9

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#416

Please see above PR for status and review.

Comment 10

[Ed Morley [:emorley]]

Comment on attachment 8576035 [details] [review]
treeherder-ui-PR#416

Stealing; lgtm.
Going to grunt build + push soon, if you wanted to merge this now?

Comment 11

[Jonathan French (:jfrench)]

Will do.

Comment 12

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/549495ba9e59e7b45927ae95741a3acc35b0c9eb
Bug 1137456 - Consolidate the pinboard save/clear-all cluster

https://github.com/mozilla/treeherder-ui/commit/db32dafd3cbff2915442b2233308311d57b4f27e
Merge pull request #416 from tojonmz/consolidate-save-cluster

Bug 1137456 - Consolidate the pinboard save/clear-all cluster

Comment 13

[Jonathan French (:jfrench)]

Marking fixed per above merge. I will verify on the next push to stage/prod.

Comment 14

[Jonathan French (:jfrench)]

This has been approved by sheriffs on stage, so marking verified fixed.

Comment 15

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8aa09378ca481eec2aa99c1c31b3ce559a96c9d2
Bug 1137456 - Consolidate the pinboard save/clear-all cluster

https://github.com/mozilla/treeherder/commit/e2ad59b81ec23d31eb5cfa0c81ee5b7566fe0e44
Merge pull request #416 from tojonmz/consolidate-save-cluster

Bug 1137456 - Consolidate the pinboard save/clear-all cluster