If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

VP9 support in signaling and conduit/pipeline code

RESOLVED FIXED in Firefox 39

Status

()

Core
WebRTC: Signaling
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla39
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1090742 +++

This bug covers the upstream (webrtc.org) basic portions of vp9 support; it also doesn't cover things about *when* VP9 should be preferred or switched to/from (which may require allowing accepting multiple codecs, which we don't do yet)

Note that webrtc branch 40 has vp9 codec support, but it's incomplete and does not include any packetization, and many codepaths don't account for vp9 as a possibility.
(Assignee)

Comment 1

3 years ago
Created attachment 8570158 [details] [diff] [review]
Basic vp9 support added to upstream (using 'generic' packetization)
(Assignee)

Comment 2

3 years ago
Created attachment 8570159 [details] [diff] [review]
Fix depacketization of "Generic" encoded RTP video
(Assignee)

Comment 3

3 years ago
Created attachment 8570712 [details] [diff] [review]
Basic vp9 support added to upstream (using 'generic' packetization)
(Assignee)

Updated

3 years ago
Attachment #8570158 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8570159 - Flags: review?(pkerr)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8570712 [details] [diff] [review]
Basic vp9 support added to upstream (using 'generic' packetization)

Note: this is known-to-be incomplete, as upstream isn't ready (no VP9 packetization, etc), and I may well back this out before applying the next pull from upstream, then see what they missed (assuming they get to this before the next time we pull).
Attachment #8570712 - Flags: review?(pkerr)

Updated

3 years ago
Attachment #8570159 - Flags: review?(pkerr) → review+

Comment 5

3 years ago
Comment on attachment 8570712 [details] [diff] [review]
Basic vp9 support added to upstream (using 'generic' packetization)

Review of attachment 8570712 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Left some minor questions.

::: media/webrtc/trunk/webrtc/modules/video_coding/main/source/video_sender.cc
@@ +136,5 @@
>                    << sendCodec->plName << ". Error code: " << ret;
>      return VCM_CODEC_ERROR;
>    }
>  
> +  // XXX fix VP9

Is there a bug tracking this fix?

::: media/webrtc/trunk/webrtc/video_engine/vie_codec_impl.cc
@@ +87,5 @@
>                   << codec.codecSpecific.H264.spsLen
>                   << ", ppslen: "
>                   << codec.codecSpecific.H264.ppsLen;
> +  } else if (codec.codecType == kVideoCodecVP9) {
> +    LOG(LS_INFO) << "VP9 specific settings";

I think it would be helpful to have some basic information here, as with the VP8 codec above.

::: media/webrtc/trunk/webrtc/video_engine/vie_encoder.cc
@@ +635,5 @@
>                         &codec_specific_info);
>      return;
>    }
>  #endif
> +  // XXX fix VP9

Is there a bug for this fix?
Attachment #8570712 - Flags: review?(pkerr) → review+
(Assignee)

Updated

3 years ago
Blocks: 1138629
(Assignee)

Comment 6

3 years ago
> ::: media/webrtc/trunk/webrtc/video_engine/vie_codec_impl.cc
> @@ +87,5 @@
> >                   << codec.codecSpecific.H264.spsLen
> >                   << ", ppslen: "
> >                   << codec.codecSpecific.H264.ppsLen;
> > +  } else if (codec.codecType == kVideoCodecVP9) {
> > +    LOG(LS_INFO) << "VP9 specific settings";
> 
> I think it would be helpful to have some basic information here, as with the
> VP8 codec above.

None of that info is filled in currently, given the lack of packetization data.  It's largely a placeholder
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf6cd84214a5
https://hg.mozilla.org/integration/mozilla-inbound/rev/29c8632b348e
https://hg.mozilla.org/mozilla-central/rev/bf6cd84214a5
https://hg.mozilla.org/mozilla-central/rev/29c8632b348e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.