1137480 - Supersearch autocomplete chooses the wrong item

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P3)

Description

[(Away)]

STR: Supersearch for: "version", "has terms", "35.0<enter>"

Expected: The search term is 35.0
Actual: The search term is 35.0.1

Similarly: "36.0<enter>" selects "36.0b"

I would expect that if the typed entry matches a known term, it should be used unmodified.

Comment 1

[(Away)]

(This is perhaps unrelated, but I always find the dropdown/autocomplete thing slow and clunky. I'd be perfectly happy with a dumb text box :-))

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Yeah the list of versions is pretty big, and that makes it slow. I agree that removing the suggested versions entirely could be a better choice, but we'd want to keep them for the simple UI. Maybe as a first step I can just remove all the duplicates, because there are a lot of them. Also, I'll apply a better sorting algorithm to those boxes, which should solve your problem.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/66a4c97b39e9a5d88a1b105dbba85e1de69769a8
Fixes bug 1137480 - Removed duplicates from versions in Super Search.

https://github.com/mozilla/socorro/commit/5ea9a69dfc875a5bc57bd0f155dd5a874c0fc1d7
Merge pull request #2645 from AdrianGaudebert/1137480-super-search-versions

Fixes bug 1137480 - Removed duplicates from versions in Super Search.

Comment 4

[(Away)]

(In reply to David Major [:dmajor] from comment #0)
> Similarly: "36.0<enter>" selects "36.0b"

This seems to be happening again; did something change? (Perhaps the "b1" stuff?)

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

I confirm this is happening again, but I do not know why. I'll investigate.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Changing this bug to be a P3. It's interesting, but probably not something we have time for. If there's a compelling reason why this has urgency and should get done now, please let us know in a comment!

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

So, I redid how the webapp knows what versions are for what product a couple of months ago. In the process of doing that, the Versions field of the search form changed a bit. If you type something like "62.0" and there was a final 62.0 release, then it won't complete to 62.0b because 62.0 came after 62.0b.

However, if there was a 62.0.1, then it'll complete to that because that comes after 62.0.

I think that's the best we're going to be able to do this given that it's an autocomplete field without redoing the ux altogether which I'm a little loathe to do right now. You'll have to type the version number and then hit up/down until you get the right one.

I'm going to re-mark this as FIXED, but if that's disagreeable, I'll mark it as WONTFIX.