1137523 - Unprefix most js_* functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

This patch moves all js_* functions inside the 'js' namespace and removes the js_* prefix. There were a lot of them, here are some examples:

* js_Report{OverRecursed,OutOfMemory,...}
* js_Array/js_String/js_Date, I renamed those to js::{Array,String,Date}Constructor.
* js_IdIsIndex
* js_Init*Class
* ...

I didn't touch functions like js_strlen, js_strtod, js_free etc: strlen/strtod/free will probably be ambiguous/confusing. I also didn't rename constants/globals like js_CodeSpec.

The patch is huge, but the changes were pretty mechanical for the most part. I also removed some unused functions from jsopcode.cpp.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Wow, awesome job Jan!

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 8570229 [details] [diff] [review]
Patch

Review of attachment 8570229 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 3

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/069853eac6cc

Thanks for the quick review.

Comment 4

[Jan de Mooij [:jandem]]

Realized I forgot js_Dump*, js_GetSrcNoteOffset/js_SrcNoteLength and js_generic_native_method_dispatcher. These should be pretty trivial though.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/069853eac6cc

Comment 6

[Brian Hackett [Laid off!]]

Hmm, I guess I missed this but why does this patch remove js_DumpPC and js_DumpScript?  These are important debugging functions and I don't see any obvious replacements for them.

Comment 7

[Brian Hackett [Laid off!]]

OK, I see this mentioned in comment 0 now.  js_DumpPC and js_DumpScript can still be called from the debugger.

Comment 8

[Jan de Mooij [:jandem]]

Attachment: Part 2

This patch unprefixes the js_Dump* functions, js_SrcNoteLength and js_GetSrcNoteOffset, and renames js_generic_native_method_dispatcher to GenericNativeMethodDispatcher.

I also added js_DumpScript and js_DumpPC back as js::DumpScript/js::DumpPC, sorry about that.

Comment 9

[Brian Hackett [Laid off!]]

Comment on attachment 8571314 [details] [diff] [review]
Part 2

Review of attachment 8571314 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Jan de Mooij [:jandem]]

Part 2:

https://hg.mozilla.org/integration/mozilla-inbound/rev/06f2d4958f52

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/06f2d4958f52