1137549 - [RTL][Contacts] The string "No Contacts Found" is left-aligned and needs more spacing between lines

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Yeojin Chung [:YeojinC]]

Attachment: NoContactsFound.png

Description:
When there is no search result from the contact list, the string "No Contacts Found" appears left-aligned.

Repro Steps:
1) Update a Flame to 20150226010233.
2) Set the device language in Arabic under Settings > Language.
3) Open Contacts app.
4) Select "+" icon, and create a new contact with first name "abc" and last name "def".'
5) On the main contacts screen, tap the search field.
6) Type "x".
7) Observe the string "No Contacts Found".

Actual:
The "No Contacts Found" string is left-aligned, and the first and the second line overlaps without enough spacing in between.

Expected:
The "No Contacts Found" string is right-aligned, and there is enough spacing between the lines.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150226010233
Gaia: 7894b929f1b0394f3c997f72a6482bc7813e758d
Gecko: dd6353d61993
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 5/5
See attached: screenshot

Comment 1

[Yeojin Chung [:YeojinC]]

This issue also reproduces on Flame 2.2.

Result: The "No Contacts Found" string is left-aligned, and the first and the second line overlaps without enough spacing in between.
 
Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150226002503
Gaia: bf24aa57fa7760260ab05d1f53242c8d8ae59e83
Gecko: 363123044e61
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Issue impacting RTL users.

Comment 3

[Wilfred Mathanaraj [:WDM]]

triage: critical and must be fixed

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1137549 > mozilla-b2g:master

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8571332 [details] [review]
[gaia] arcturus:bug-1137549 > mozilla-b2g:master

Changing r? to Fernando since Sergi seems to be busy.

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6212252fc1541557d94bb34940c445153c93a762

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8571332 [details] [review]
[gaia] arcturus:bug-1137549 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
RTL
[User impact] if declined:
Bad user experience
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
Low
[String changes made]:
None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/8f393401fbb585b19ee27bca444b1737cd83e174

Comment 9

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed in the lates Nightly Flame 3.0 and 2.2 builds.

Actual Results: The "No contacts found" text is correctly right aligned and does not overlap with itself

Environmental Variables:
Device: Flame 3.0
BuildID: 20150311110236
Gaia: 2b87ee8e7e2ec30a9851b6b59a899006a98767ab
Gecko: bc6aeea72290
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150311002522
Gaia: 3f032238a52f08e4c2f68a47ad065a96eb22d470
Gecko: 004fa1cb1dd4
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0