1137643 - waitForEvents has errors

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Markus Adrario [:Taraman]]

Attachment: fix_waitForEvents.diff

+++ This bug was initially created as a clone of Bug #1118012 +++
In the TB-Version of Mozmill, the function waitForEvents.wait() produces 2 errors:
- ex is not defined
- this.node is not defined

The Problem is in [1], which is the copy, Thunderbird uses for its Mozmill.
first error is caused by a typo (ex ISO e)
second error is caused by this.node not being in scope. This is addressed by using "self".

The Bug is already fixed in Mozmill (see bug 118012).

Since Thunderbird uses an old version witch will not get updated, this fixes it here.
Patch for comm-central is attached.

[1]: http://mxr.mozilla.org/comm-central/source/mail/test/resources/mozmill/mozmill/extension/resource/modules/controller.js#133

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 8570396 [details] [diff] [review]
fix_waitForEvents.diff

Given this is calendar related, I think Philipp can review this.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8570396 [details] [diff] [review]
fix_waitForEvents.diff

Review of attachment 8570396 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/test/resources/mozmill/mozmill/extension/resource/modules/controller.js
@@ +132,3 @@
>        utils.waitFor(function() {
> +        return self.node.firedEvents[e] == true;
> +      }, "Timeout happened before event '" + e +"' was fired.", timeout, interval);

Can we use latest ES6 here? If so, you could just use an arrow function and keep |this|. I don't really mind either way though, r=philipp

Comment 3

[Markus Adrario [:Taraman]]

Actually this is a general testing issue.
But since the calendar mozmill tests are the only ones right now who use this function, I'll go with the review of Philipp.

I'll have a look at the -> in ES6
But the patch went into Mozmill 2 already as is.

Comment 4

[Markus Adrario [:Taraman]]

This patch is lying around now for some time.
If it's ok, I like to check it in as is, since as mentioned in the previous post, it is in Mozmill 2.0 exactly the same way.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Sure, go ahead!

Comment 6

[Markus Adrario [:Taraman]]

pushed to comm-central

-> https://hg.mozilla.org/comm-central/rev/7744a4fe857d4e5297a3a9312b1c6370ef294eac