Closed Bug 1137672 Opened 5 years ago Closed 5 years ago
Lightning fails to send email for event replies
Attachment #8570448 - Flags: review?(philipp) → review?(makemyday)
Comment on attachment 8570448 [details] [diff] [review] Fix sending event reply emails Review of attachment 8570448 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for finding this and taking care. r=makemyday with the comment below considered. Please request approval for aurora on the final patch, this needs to be backported to 4.0 ::: calendar/itip/calItipEmailTransport.js @@ +227,5 @@ > // Add this recipient id to the list. > toList += rId; > } > + let composeUtils = Components.classes["@mozilla.org/messengercompose/computils;1"] > + .createInstance(Components.interfaces.nsIMsgCompUtils); Please indent .createInstance to be aligned with .classes
Attachment #8570448 - Flags: review?(makemyday) → review+
Now with fixed indentation
Comment on attachment 8570909 [details] [diff] [review] Fix sending event reply emails (r=makemyday) [Approval Request Comment] User impact if declined: Event replies are not sent via email Testing completed (on c-c, etc.): Worked for me Risk to taking this patch (and alternatives if risky): low; just moves an existing variable before it is used String/UUID changes: none
Attachment #8570909 - Flags: approval-calendar-aurora?(philipp)
Attachment #8570909 - Flags: approval-calendar-aurora?(philipp) → approval-calendar-aurora+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.1
This still needs to be pushed to comm-aurora!
You need to log in before you can comment on or make changes to this bug.