Closed
Bug 1137672
Opened 5 years ago
Closed 5 years ago
Lightning fails to send email for event replies
Categories
(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect, major)
Tracking
(Not tracked)
RESOLVED
FIXED
4.0.0.1
People
(Reporter: bokeefe, Assigned: bokeefe)
Details
Attachments
(1 file, 1 obsolete file)
2.84 KB,
patch
|
bokeefe
:
review+
Fallen
:
approval-calendar-aurora+
|
Details | Diff | Splinter Review |
With the latest nightly build of Lightning, accepting (or declining) an invitation prompts to send a reply email, but the email isn't sent. There's a javascript error in the console: calItipEmailTransport.js:230: "composeUtils" is not defined (paraphrased, because I closed Thunderbird). Moving the definition from line 323 before that fixed it for me.
Assignee | ||
Comment 1•5 years ago
|
||
Attachment #8570448 -
Flags: review?(philipp)
Updated•5 years ago
|
Attachment #8570448 -
Flags: review?(philipp) → review?(makemyday)
Comment 2•5 years ago
|
||
Comment on attachment 8570448 [details] [diff] [review] Fix sending event reply emails Review of attachment 8570448 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for finding this and taking care. r=makemyday with the comment below considered. Please request approval for aurora on the final patch, this needs to be backported to 4.0 ::: calendar/itip/calItipEmailTransport.js @@ +227,5 @@ > // Add this recipient id to the list. > toList += rId; > } > + let composeUtils = Components.classes["@mozilla.org/messengercompose/computils;1"] > + .createInstance(Components.interfaces.nsIMsgCompUtils); Please indent .createInstance to be aligned with .classes
Attachment #8570448 -
Flags: review?(makemyday) → review+
Assignee | ||
Comment 3•5 years ago
|
||
Now with fixed indentation
Attachment #8570448 -
Attachment is obsolete: true
Attachment #8570909 -
Flags: review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 8570909 [details] [diff] [review] Fix sending event reply emails (r=makemyday) [Approval Request Comment] User impact if declined: Event replies are not sent via email Testing completed (on c-c, etc.): Worked for me Risk to taking this patch (and alternatives if risky): low; just moves an existing variable before it is used String/UUID changes: none
Attachment #8570909 -
Flags: approval-calendar-aurora?(philipp)
Updated•5 years ago
|
Attachment #8570909 -
Flags: approval-calendar-aurora?(philipp) → approval-calendar-aurora+
Updated•5 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.1
Comment 6•5 years ago
|
||
This still needs to be pushed to comm-aurora!
Updated•5 years ago
|
Target Milestone: 4.1 → 4.0
You need to log in
before you can comment on or make changes to this bug.
Description
•