Lightning fails to send email for event replies

RESOLVED FIXED in 4.0.0.1

Status

Calendar
E-mail based Scheduling (iTIP/iMIP)
--
major
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bokeefe, Assigned: bokeefe)

Tracking

Lightning 4.1
4.0.0.1

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
With the latest nightly build of Lightning, accepting (or declining) an invitation prompts to send a reply email, but the email isn't sent. There's a javascript error in the console:

calItipEmailTransport.js:230: "composeUtils" is not defined (paraphrased, because I closed Thunderbird).

Moving the definition from line 323 before that fixed it for me.
(Assignee)

Comment 1

3 years ago
Created attachment 8570448 [details] [diff] [review]
Fix sending event reply emails
Attachment #8570448 - Flags: review?(philipp)
Attachment #8570448 - Flags: review?(philipp) → review?(makemyday)

Comment 2

3 years ago
Comment on attachment 8570448 [details] [diff] [review]
Fix sending event reply emails

Review of attachment 8570448 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for finding this and taking care. r=makemyday with the comment below considered.

Please request approval for aurora on the final patch, this needs to be backported to 4.0

::: calendar/itip/calItipEmailTransport.js
@@ +227,5 @@
>                      // Add this recipient id to the list.
>                      toList += rId;
>                  }
> +                let composeUtils = Components.classes["@mozilla.org/messengercompose/computils;1"]
> +                                         .createInstance(Components.interfaces.nsIMsgCompUtils);

Please indent .createInstance to be aligned with .classes
Attachment #8570448 - Flags: review?(makemyday) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8570909 [details] [diff] [review]
Fix sending event reply emails (r=makemyday)

Now with fixed indentation
Attachment #8570448 - Attachment is obsolete: true
Attachment #8570909 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

3 years ago
Comment on attachment 8570909 [details] [diff] [review]
Fix sending event reply emails (r=makemyday)

[Approval Request Comment]
User impact if declined: Event replies are not sent via email
Testing completed (on c-c, etc.): Worked for me
Risk to taking this patch (and alternatives if risky): low; just moves an existing variable before it is used
String/UUID changes: none
Attachment #8570909 - Flags: approval-calendar-aurora?(philipp)
Attachment #8570909 - Flags: approval-calendar-aurora?(philipp) → approval-calendar-aurora+

Comment 5

3 years ago
https://hg.mozilla.org/comm-central/rev/ceca5f03cf4b

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.1
This still needs to be pushed to comm-aurora!

Comment 7

3 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/6d8eb2a47e73
Target Milestone: 4.1 → 4.0
You need to log in before you can comment on or make changes to this bug.