1137672 - Lightning fails to send email for event replies

Status: RESOLVED FIXED

Description

[Brian O'Keefe [:bokeefe]]

With the latest nightly build of Lightning, accepting (or declining) an invitation prompts to send a reply email, but the email isn't sent. There's a javascript error in the console:

calItipEmailTransport.js:230: "composeUtils" is not defined (paraphrased, because I closed Thunderbird).

Moving the definition from line 323 before that fixed it for me.

Comment 1

[Brian O'Keefe [:bokeefe]]

Created attachment 8570448 [details] [diff] [review]
Fix sending event reply emails

Comment 2

[[:MakeMyDay]]

Comment on attachment 8570448 [details] [diff] [review]
Fix sending event reply emails

Review of attachment 8570448 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for finding this and taking care. r=makemyday with the comment below considered.

Please request approval for aurora on the final patch, this needs to be backported to 4.0

::: calendar/itip/calItipEmailTransport.js
@@ +227,5 @@
>                      // Add this recipient id to the list.
>                      toList += rId;
>                  }
> +                let composeUtils = Components.classes["@mozilla.org/messengercompose/computils;1"]
> +                                         .createInstance(Components.interfaces.nsIMsgCompUtils);

Please indent .createInstance to be aligned with .classes

Comment 3

[Brian O'Keefe [:bokeefe]]

Created attachment 8570909 [details] [diff] [review]
Fix sending event reply emails (r=makemyday)

Now with fixed indentation

Comment 4

[Brian O'Keefe [:bokeefe]]

Comment on attachment 8570909 [details] [diff] [review]
Fix sending event reply emails (r=makemyday)

[Approval Request Comment]
User impact if declined: Event replies are not sent via email
Testing completed (on c-c, etc.): Worked for me
Risk to taking this patch (and alternatives if risky): low; just moves an existing variable before it is used
String/UUID changes: none

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/ceca5f03cf4b

Comment 6

[Martin Schröder [:martinschroeder]]

This still needs to be pushed to comm-aurora!

Comment 7

[[:MakeMyDay]]

https://hg.mozilla.org/releases/comm-aurora/rev/6d8eb2a47e73