1137675 - Unable to unclassify a classified job

Status: RESOLVED FIXED

(Tree Management :: Treeherder: API, defect, P2)

Description

[Rakesh]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150224133805

Steps to reproduce:

I ) Classify and unclassify a job , it won't be displayed in "only classified mode"
II) On page relaod, unclassified job shows up in "only classified mode"


Actual results:

Unclassfying a classified job makes it visible in "only classified mode"
This is fixed in Bug 1113396.
https://bugzilla.mozilla.org/show_bug.cgi?id=1113396

Now on reloading page, the above unclassified job shows up in "only classified mode".


Expected results:

Job failure classification should be assigned "1" to make it unclassified job. 
This is fixed in Bug 1113396. In the backend, while deleting classification, job classification is assigned a value "null" which doesn't make it an unclassified job. 

https://github.com/mozilla/treeherder-service/blob/master/treeherder/webapp/api/note.py#L73

so, on reloading page, it shows up in "only classified mode" which displays jobs which are not classified ( since it is marked as "not an unclassified job").

https://github.com/mozilla/treeherder-service/blob/master/treeherder/webapp/api/note.py#L73

Comment 1

[Rakesh]

Attachment: patch

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8571474 [details] [review]
patch

Leaving as a ? to I remember to merge it.  But looks good once you fix up the commit message.

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/7b516d0254de5e4a114009bb729a1921059a3959
Bug 1137675 - sql query fixed to unclassify a classified job

https://github.com/mozilla/treeherder-service/commit/87f138aa45ea67774be7c4d2fc25fac1653e9fbc
Merge pull request #406 from dewgeek/bug1137675

Bug 1137675 - updated sql query to unclassify a classified job.

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8571474 [details] [review]
patch

Actually not sure of the sql syntax myself, but if it's good enough for Cam, it's good enough for me.