1137713 - No transition when entering/exiting the task manager from/to the homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Chris Lord [:cwiiis]]

If you enter or exit the task manager from the home-screen, it appears/disappears instantly. This looks very janky, especially when going to the home-screen, as the home-screen still performs its zoom-out animation.

I guess there are two issues here:

1- No transition when entering/exiting from/to the homescreen on the task manager.
2- Incorrect homescreen transition when exiting task manager that was entered from the homescreen.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1137713-taskmanager-homescreen-transition > mozilla-b2g:master

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 8583943 [details] [review]
[gaia] Cwiiis:bug1137713-taskmanager-homescreen-transition > mozilla-b2g:master

For whoever gets there first - Etienne's on PTO Friday, so tagging Alive in case I've finished too late.

This adds transitions to and from the homescreen when opening the task manager, as I believe we had in previous versions (but I may be mistaken). Just a simple fade, as spacially, the task manager is on the same level as the homescreen (tagged ui-review to make sure).

Structually, homescreen is now handled a bit more like an app in the task manager, with respect to open/close transitions. The biggest change is in how we make the apps moz-element'able - as the fade exposes them, I've placed them behind the screen div, which puts them in the viewport, but allows them to remain invisible during the fade. I don't believe this will affect performance.

Comment 3

[Eric Pang [:epang] UX]

Comment on attachment 8583943 [details] [review]
[gaia] Cwiiis:bug1137713-taskmanager-homescreen-transition > mozilla-b2g:master

Visually this looks good to me (much better then before).  Flagging Francis to take a look at it based on the spatial model. Thanks!

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8583943 [details] [review]
[gaia] Cwiiis:bug1137713-taskmanager-homescreen-transition > mozilla-b2g:master

r=me with nit

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 8583943 [details] [review]
[gaia] Cwiiis:bug1137713-taskmanager-homescreen-transition > mozilla-b2g:master

Adding ui-review?tiffanie in case she gets to it before Francis - it's going to become increasingly difficult to uplift stuff to 2.2, I'd quite like to get this in asap.

Comment 6

[Francis Djabri [:djabber]]

Comment on attachment 8583943 [details] [review]
[gaia] Cwiiis:bug1137713-taskmanager-homescreen-transition > mozilla-b2g:master

We never got around to implementing the new spatial model in 2.2, so it doesn't really impact this bug. As Eric says, this looks better than before, so it's good with me.

Comment 7

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#pyz973jJQf-lZrsh8Toriw

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 8

[Chris Lord [:cwiiis]]

Seems music is failing tests? n?me to verify that that's actually caused by this patch - seems unlikely, but I won't rule it out without testing.

Comment 9

[Chris Lord [:cwiiis]]

I get the same failure locally on master, merged manually: https://github.com/mozilla-b2g/gaia/commit/fd48899451df1a735c1ccb3244c126c7d8dd1c26

Comment 10

[Chris Lord [:cwiiis]]

Comment on attachment 8583943 [details] [review]
[gaia] Cwiiis:bug1137713-taskmanager-homescreen-transition > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Janky transition when entering/exiting task manager from/to the homescreen.
[Testing completed]: Manual testing and task manager is covered by reasonably extensive automated testing.
[Risk to taking this patch] (and alternatives if risky): Low, but not very low.
[String changes made]: None

Nominating this as this is a very high-impact polish bug on a feature that users are likely to use regularly.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/e9e11064a55943389fba3a8ef27e56fa3c28248b

Comment 12

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest nightly build of Flame v2.2&Master by the STR in Comment 0.

Actual results: There is simple transition when entering/exiting task manager from/to the homescreen.
See attachment: Verified_Flame_v2.2.3gp
Reproduce rate: 0/10


Device: Flame v2.2 (Verified) 
Build ID               20150713002503
Gaia Revision          84d0c76370dcd3d25813b00de55194730884355b
Gaia Date              2015-07-09 13:09:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d59402ba85a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150713.041147
Firmware Date          Mon Jul 13 04:11:59 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master (Verified)
Build ID               20150713010204
Gaia Revision          e4b63559eba364892867eb381c3002d6518e5d6a
Gaia Date              2015-07-10 14:29:23
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eab21ec484bb
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150713.043935
Firmware Date          Mon Jul 13 04:39:47 EDT 2015
Bootloader             L1TC000118D0

Comment 13

[Shally Li（leave from Mozilla）]

Attachment: Verified_Flame_v2.2.3gp