1137724 - Update email subscription center to accommodate new Firefox iOS email preference

Status: RESOLVED FIXED

(www.mozilla.org :: Newsletters, defect)

Description

[Ben Niolet]

Attachment: ios_preference_center.png

I'm not sure if I have filed this bug in the right category or not, so apologies if this is misfiled. I'm happy to file individual bugs for each translation if necessary.

The new Firefox iOS email signup is live and has it's own localized confirmation message for en, es, pt-BR, fr, de, id, hu, ru, pl. (see bugs:

 https://bugzilla.mozilla.org/show_bug.cgi?id=1126578

and 

https://bugzilla.mozilla.org/show_bug.cgi?id=1136960

The preference center needs two changes: 

1) Localization of the descriptive text that's in basket.

2) Make Firefox iOS an "interest" and not a "newsletter"

The Firefox iOS communications will not be a recurring stream. It is currently listed in the newsletter section of the preference center. It needs to be treated as an interest. (see screenshot).

Comment 1

[Francesco Lodolo [:flod]]

Where does this text live? I assume it's not on Bedrock, otherwise I would have probably seen it.
Can you give me a link to a live page where I can check the actual markup?

It would be good to establish a clear workflow for this when you add a newsletter:
* Ping l10n-drivers to add the necessary strings to lang files, with a reasonable time available for localization (not 2 days).
* Wait for involved locales to translate the strings.

Comment 2

[Ben Niolet]

Process sounds good, flod. 

Pinging pmac for help with where this text lives.

Comment 3

[Francesco Lodolo [:flod]]

To clarify: I know where the final strings should go (newsletter.lang), but I don't know where to take them.

I think last time (bug 1087579), I copied them from the HTML of the newsletter pref center. But I need a working link for that, with iOS enabled.

Comment 4

[Francesco Lodolo [:flod]]

OK, subscribed and found the text.

> Be the first to know when Firefox is available for iOS devices.

Unfortunately SVN is dead, so I can't really add the string until is back.

Comment 5

[Paul [:pmac] McLanahan]

The text doesn't live anywhere yet. I will live in basket when we fix the email preference center (/newsletter/existing/<token>/). It will live in the markup on that page, but we've not added it yet.

Comment 6

[Ben Niolet]

Is there anything I can do to get this moving? Do I need to file separate translation bugs?

Comment 7

[Francesco Lodolo [:flod]]

The only locales missing the description are hu and pt-BR. We can try to ping/NI localizers, but the request is already on their dashboard, and they have some back-log to go through.

Comment 8

[Ben Niolet]

Thanks, flod!

Comment 9

[Ben Niolet]

What about the issue of relocating where the iOS flag lives in on the page. Mike is that a question for you or someone else?

Comment 10

[Paul [:pmac] McLanahan]

That's me. Just need some time.

Comment 11

[Ben Niolet]

Oh my fault sir. Didn't realize. Carry on, then.

Comment 12

[Paul [:pmac] McLanahan]

I let this slip by. My apologies. When do we need this?

Comment 13

[Ben Niolet]

No worries. Timing is good since the app is launching in short order. Next couple weeks would be lovely.

Comment 14

[Kohei Yoshino [:kohei]]

Attachment: Screen Shot 2015-09-10 at 13.57.46.png

Tested :pmac's PR and looks good to me. It goes last instead of under Firefox OS, but the position should be controlled in the Basket with the "order" field.

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d9ce5fd816ce5a7d675e0825cad31cfd3ca0a378
Bug 1137724: Move iOS newsletter to interests section.

https://github.com/mozilla/bedrock/commit/7490dee1d713c13a08cdda55ab902d5c4a91a177
Merge pull request #3283 from pmclanahan/move-ios-newsletter-interest-1137724

Bug 1137724: Move iOS newsletter to interests section.

Comment 16

[Jessilyn Davis]

Looks like this went live and is looking good.