1137814 - nsAString and nsACString in URL.cpp/h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: url.patch

Currently we use nsString and nsCString everywhere in these files.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8570605 [details] [diff] [review]
url.patch

Review of attachment 8570605 [details] [diff] [review]:
-----------------------------------------------------------------

IIUC this works:

void Getter(nsCString& ref)
{
  ref = ...;
}

nsAutoCString a;
Getter(a);

So I don't see why the same won't work for ns(Auto)String. In that case we don't need this patch. Waiting for clarification on IRC.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: 231194.diff

https://treeherder.mozilla.org/#/jobs?repo=try&revision=727be4bfd099

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7aee53b910f

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f7aee53b910f