Closed Bug 1137814 Opened 5 years ago Closed 5 years ago

nsAString and nsACString in URL.cpp/h

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch url.patch (obsolete) — Splinter Review
Currently we use nsString and nsCString everywhere in these files.
Attachment #8570605 - Flags: review?(nsm.nikhil)
Comment on attachment 8570605 [details] [diff] [review]
url.patch

Review of attachment 8570605 [details] [diff] [review]:
-----------------------------------------------------------------

IIUC this works:

void Getter(nsCString& ref)
{
  ref = ...;
}

nsAutoCString a;
Getter(a);

So I don't see why the same won't work for ns(Auto)String. In that case we don't need this patch. Waiting for clarification on IRC.
Attachment #8570605 - Flags: review?(nsm.nikhil)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f7aee53b910f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.