Closed Bug 1137820 Opened 5 years ago Closed 5 years ago

gecko: B2G Inbound scheduled jobs are incorrect?

Categories

(Taskcluster :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlal, Assigned: wcosta)

References

Details

Attachments

(4 files, 1 obsolete file)

The current b2g-inbound jobs look like what we wanted to deploy on cypress and only include a minimal set of jobs http://docs.taskcluster.net/tools/task-inspector/#s2fXfxeDSXKBjlymEnFn_Q / http://docs.taskcluster.net/tools/task-graph-inspector/#VPaONry1R1Cs8sQKBmkYzQ
Assignee: nobody → wcosta
Status: NEW → ASSIGNED
Reviewed this on IRC with wcosta.  Since the job_flags for b2g-i is inheriting from a job_flags that has no builds/tests, b2g-i will only run what's specific in its job_flags, which is just the flame-kk builds/tests.

There are two options here, one to inherit from m-c's job flags within b2g-i job flags (one line change):
https://gist.github.com/gregarndt/4e453ac503cc54561d1b

Or be explicit in b2g-i's job flags and list out each build/test is allowed to run similar to what has been done for the other branches configured.
https://gist.github.com/gregarndt/e4f01b9db160043634c3
Depends on: 1139066
Attached file MozReview Request: bz://1137820/wcosta (obsolete) —
/r/4635 - [PATCH 1/3] Bug 1137820 part 1: Update phone build image.
/r/4637 - [PATCH 2/3] Bug 1137820 part 2: Inherit cypress and b-i branches from m-c.
/r/4639 - [PATCH 3/3] Bug 1137820 part 3: Move phone builder scripts to gecko tree.

Pull down these commits:

hg pull review -r 9af0e860524e505ca43e24a8b8e49c4403a52de8
Attachment #8572725 - Flags: review?(jlal)
Attachment #8572725 - Flags: review?(garndt)
Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

https://reviewboard.mozilla.org/r/4633/#review3811

Ship It!
Attachment #8572725 - Flags: review?(garndt) → review+
Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

r+ (with changes we discussed on irc)
Attachment #8572725 - Flags: review?(jlal) → review+
Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

/r/4635 - Bug 1137820 part 1: Update phone build image.
/r/4637 - Bug 1137820 part 2: Inherit cypress and b-i branches from m-c.
/r/4639 - Bug 1137820 part 3: Move phone builder scripts to gecko tree.

Pull down these commits:

hg pull review -r 890ff0d693425f4ff814b60367244957e5054de8
Attachment #8572725 - Flags: review?(jlal)
Attachment #8572725 - Flags: review?(garndt)
Attachment #8572725 - Flags: review+
I've only changed patch 3, based on our discussion on irc.
Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

lgtm
Attachment #8572725 - Flags: review?(jlal) → review+
Attachment #8572725 - Flags: review?(garndt) → review+
Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

/r/4635 - Bug 1137820 part 1: Update phone build image.
/r/4637 - Bug 1137820 part 2: Inherit cypress and b-i branches from m-c.
/r/4639 - Bug 1137820 part 3: Move phone builder scripts to gecko tree.
/r/5109 - Bug 1137820 part 4: Make hg.m.o mozharness the default repo.

Pull down these commits:

hg pull review -r 89cbc97ae633956bf6fcc77012fbd30ced394055
Attachment #8572725 - Flags: review?(jlal)
Attachment #8572725 - Flags: review+
This latest review only adds a new commit to make hg.m.o/build/mozharness the default mozharness repository.
Attachment #8572725 - Flags: review?(jlal)
Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

https://reviewboard.mozilla.org/r/4633/#review4241

::: testing/taskcluster/mach_commands.py
(Diff revision 3)
> -        default='https://github.com/lightsofapollo/build-mozharness',
> +        default='https://hg.mozilla.org/build/mozharness',

I might switch this back to a staging mozharness if needed later (this is fine for now and obviously the right value)

::: testing/taskcluster/tasks/branches/b2g-inbound/job_flags.yml
(Diff revision 3)
> +tests:

I don't understand the logic for this part? I think you can remove this entirely... The gaia build sytem is totally independant of the phone builds.
Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

https://reviewboard.mozilla.org/r/4633/#review4243

Ship It!
Attachment #8572725 - Flags: review+
See Also: → 1142692
Depends on: 1142801
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #15)
> https://hg.mozilla.org/mozilla-central/rev/1b249bf61591

This caused bug 1142938.
Depends on: 1142938
Attachment #8572725 - Attachment is obsolete: true
Attachment #8619619 - Flags: review+
Attachment #8619620 - Flags: review+
Attachment #8619621 - Flags: review+
Attachment #8619622 - Flags: review+
Component: TaskCluster → General
Product: Testing → Taskcluster
Target Milestone: mozilla39 → mozilla41
Version: unspecified → Trunk
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.