1137820 - gecko: B2G Inbound scheduled jobs are incorrect?

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[James Lal [:lightsofapollo]]

The current b2g-inbound jobs look like what we wanted to deploy on cypress and only include a minimal set of jobs http://docs.taskcluster.net/tools/task-inspector/#s2fXfxeDSXKBjlymEnFn_Q / http://docs.taskcluster.net/tools/task-graph-inspector/#VPaONry1R1Cs8sQKBmkYzQ

Comment 1

[Greg Arndt [:garndt]]

Reviewed this on IRC with wcosta.  Since the job_flags for b2g-i is inheriting from a job_flags that has no builds/tests, b2g-i will only run what's specific in its job_flags, which is just the flame-kk builds/tests.

There are two options here, one to inherit from m-c's job flags within b2g-i job flags (one line change):
https://gist.github.com/gregarndt/4e453ac503cc54561d1b

Or be explicit in b2g-i's job flags and list out each build/test is allowed to run similar to what has been done for the other branches configured.
https://gist.github.com/gregarndt/e4f01b9db160043634c3

Comment 2

[Wander Lairson Costa]

Attachment: MozReview Request: bz://1137820/wcosta

/r/4635 - [PATCH 1/3] Bug 1137820 part 1: Update phone build image.
/r/4637 - [PATCH 2/3] Bug 1137820 part 2: Inherit cypress and b-i branches from m-c.
/r/4639 - [PATCH 3/3] Bug 1137820 part 3: Move phone builder scripts to gecko tree.

Pull down these commits:

hg pull review -r 9af0e860524e505ca43e24a8b8e49c4403a52de8

Comment 3

[Wander Lairson Costa]

http://docs.taskcluster.net/tools/task-graph-inspector/#EIw7CkTJS-e_7KpSXO3vGQ

Comment 4

[Greg Arndt [:garndt]]

Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

https://reviewboard.mozilla.org/r/4633/#review3811

Ship It!

Comment 5

[James Lal [:lightsofapollo]]

Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

r+ (with changes we discussed on irc)

Comment 6

[Wander Lairson Costa]

Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

/r/4635 - Bug 1137820 part 1: Update phone build image.
/r/4637 - Bug 1137820 part 2: Inherit cypress and b-i branches from m-c.
/r/4639 - Bug 1137820 part 3: Move phone builder scripts to gecko tree.

Pull down these commits:

hg pull review -r 890ff0d693425f4ff814b60367244957e5054de8

Comment 7

[Wander Lairson Costa]

I've only changed patch 3, based on our discussion on irc.

Comment 8

[James Lal [:lightsofapollo]]

Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

lgtm

Comment 9

[Wander Lairson Costa]

Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

/r/4635 - Bug 1137820 part 1: Update phone build image.
/r/4637 - Bug 1137820 part 2: Inherit cypress and b-i branches from m-c.
/r/4639 - Bug 1137820 part 3: Move phone builder scripts to gecko tree.
/r/5109 - Bug 1137820 part 4: Make hg.m.o mozharness the default repo.

Pull down these commits:

hg pull review -r 89cbc97ae633956bf6fcc77012fbd30ced394055

Comment 10

[Wander Lairson Costa]

This latest review only adds a new commit to make hg.m.o/build/mozharness the default mozharness repository.

Comment 11

[Wander Lairson Costa]

Build results:
https://tools.taskcluster.net/task-inspector/#YSHcvCznRU2gbdPPsvK_sg/
https://tools.taskcluster.net/task-inspector/#O3O-dldoQz2fXodMfyJE3A/

Comment 12

[James Lal [:lightsofapollo]]

Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

https://reviewboard.mozilla.org/r/4633/#review4241

::: testing/taskcluster/mach_commands.py
(Diff revision 3)
> -        default='https://github.com/lightsofapollo/build-mozharness',
> +        default='https://hg.mozilla.org/build/mozharness',

I might switch this back to a staging mozharness if needed later (this is fine for now and obviously the right value)

::: testing/taskcluster/tasks/branches/b2g-inbound/job_flags.yml
(Diff revision 3)
> +tests:

I don't understand the logic for this part? I think you can remove this entirely... The gaia build sytem is totally independant of the phone builds.

Comment 13

[James Lal [:lightsofapollo]]

Comment on attachment 8572725 [details]
MozReview Request: bz://1137820/wcosta

https://reviewboard.mozilla.org/r/4633/#review4243

Ship It!

Comment 14

[Wander Lairson Costa]

https://hg.mozilla.org/integration/b2g-inbound/rev/bf8f1996ac21
https://hg.mozilla.org/integration/b2g-inbound/rev/54ea2ed52bd0
https://hg.mozilla.org/integration/b2g-inbound/rev/a4806eeb99c8
https://hg.mozilla.org/integration/b2g-inbound/rev/1b249bf61591

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bf8f1996ac21
https://hg.mozilla.org/mozilla-central/rev/54ea2ed52bd0
https://hg.mozilla.org/mozilla-central/rev/a4806eeb99c8
https://hg.mozilla.org/mozilla-central/rev/1b249bf61591

Comment 16

[Ed Morley [:emorley]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #15)
> https://hg.mozilla.org/mozilla-central/rev/1b249bf61591

This caused bug 1142938.

Comment 18

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1137820 part 1: Update phone build image.

Comment 19

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1137820 part 2: Inherit cypress and b-i branches from m-c.

Comment 20

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1137820 part 4: Make hg.m.o mozharness the default repo.

Comment 21

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1137820 part 3: Move phone builder scripts to gecko tree.

Comment 22

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...