Loop sever logs confusing number of room participants for "join" operations

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: abr, Assigned: rhubscher)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [loop-metrics])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Currently, when the Loop server logs a "POST /rooms/{token}" with an operation of "join", the value logged for "participants" is what the value was before the transaction, not what it was at the end of the transaction. For example, when the first person joins the room, the log message indicates a total participant count of "0".

So far, this has confused everyone I've spoken to who has looked at the logs; the expectation, I believe, is that a successful join should be logged along with the resulting participant count, not the count before the join.
(Reporter)

Updated

4 years ago
Whiteboard: [loop-metrics]
(Assignee)

Comment 1

4 years ago
Ok so what I propose to do for that.

Is to log the current number of users in case of an error (room full) and log the number of users with the new participant in case the user could join.
(Assignee)

Updated

4 years ago
Assignee: nobody → rhubscher
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 8574627 [details] [review]
Link to Github PR — #309.
Attachment #8574627 - Flags: review?(mathieu)
Attachment #8574627 - Flags: review?(mathieu) → review+
https://github.com/mozilla-services/loop-server/commit/fad6a5eb99785bdd2eb77b567ea113bfee5ef2e6
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.