1137897 - nsPluginTag::GetMimeTypes fails with NS_ERROR_NOT_AVAILABLE if mMimeTypes has no item.

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Tooru Fujisawa [:arai]]

Wacom Pressure Plug-In Ver 2.1.0-1 (/Library/Internet Plug-Ins/WacomNetscape.plugin) has no MIME-Types, and it causes following error:
> NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIPluginTag.getMimeTypes]

it's shown everytime when I open Plugins tab in Add-ons Manager.

Also, about:plugins returns empty page due to the error.

Comment 1

[Tooru Fujisawa [:arai]]

bug 1136379 comment #2
> >+CStringArrayToXPCArray(nsTArray<nsCString> & aArray,
> >+  if (!count) {
> >+    return NS_ERROR_NOT_AVAILABLE;
> 
> That's a behavior change... Maybe it's OK.

Unfortunately, that was not OK :/

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Do not throw exception from nsPluginTag::GetMimeTypes if a plug-in has no MIME-Types.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8570706 [details] [diff] [review]
Do not throw exception from nsPluginTag::GetMimeTypes if a plug-in has no MIME-Types.

r=me, and thank you!

Comment 4

[Tooru Fujisawa [:arai]]

Thank you for reviewing! :D

https://hg.mozilla.org/integration/mozilla-inbound/rev/9dcb4e943594

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9dcb4e943594