1137927 - Bottom pane should only go away when I click elsewhere if the pinboard is empty.

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I like the recent change where if I click outside of the bottom pane, it now goes away on its own. I don't like it when the bottom pane goes away after I've pinned jobs to the pinboard and I click outside of the bottom pane to copy a backout commit SHA to use in the classification field. I then have to click on a failed job up in the pushlog again to open the bottom pane back up again.

It'd be better if the going away only happens if the pinboard is empty. If stuff is pinned, I don't want the bottom pane to go away unless I've clicked the "X" to close it myself.

Comment 1

[Jonathan French (:jfrench)]

I'm up for doing this if Ed agrees. His original bug for the current behavior is bug 1042711 and -ui PR129.

Comment 2

[Ed Morley [:emorley]]

Sounds good to me :-)

Comment 3

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#415

Please see above PR for review and status.

Comment 4

[Jonathan French (:jfrench)]

Adding other sheriffs and heavy users of Treeherder for added visibility, prior to potential landing and evaluation on dev.

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8575528 [details] [review]
treeherder-ui-PR#415

This behaviour change makes sense to me.

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/cc90bf3f10c9f2d6cb8fa7a017852d8b6e37b5a6
Bug 1137927 - Persist job details panel when jobs are pinned

https://github.com/mozilla/treeherder-ui/commit/13afa583a7ef523faba4bd0f1112073562c6aa8c
Merge pull request #415 from tojonmz/pinnedjob-persist-jobpanel

Bug 1137927 - Persist job details panel when jobs are pinned

Comment 7

[Jonathan French (:jfrench)]

Marking fixed per above merge. I will verify after evaluation by others on dev and push to stage/prod.

Comment 8

[Jonathan French (:jfrench)]

This has been approved by sheriffs on stage, so marking verified fixed.

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/06fff5a9acc670f92e9734ae87694e22c7c74383
Bug 1137927 - Persist job details panel when jobs are pinned

https://github.com/mozilla/treeherder/commit/e6ee2d74580431b5f7a47757e40c17feff168911
Merge pull request #415 from tojonmz/pinnedjob-persist-jobpanel

Bug 1137927 - Persist job details panel when jobs are pinned