Closed
Bug 1137930
Opened 9 years ago
Closed 9 years ago
It should be possible to cancel sdk/event/core once
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
This was brought up in bug 952653 It should be possible to cancel a listener attached with once from sdk/event/core. This was possible with sdk/deprecated/events https://github.com/mozilla/addon-sdk/blob/master/test/test-events.js#L246-L251 and I think we can implement this for sdk/event/core too.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → evold
Priority: -- → P2
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8570795 -
Flags: review?(jsantell)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8570795 [details] [review] https://github.com/mozilla/addon-sdk/pull/1879 I'd see what the node equivalent is for this, wonder if it's possible
Attachment #8570795 -
Flags: review?(jsantell) → review+
|
||
Comment 3•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/e147e10147868e8d0f0b822b656f26783967df03 Bug 1137930 - It should be possible to cancel sdk/event/core once https://github.com/mozilla/addon-sdk/commit/82bc779ca766053d3dd9f86787118b674196bd3b Merge pull request #1879 from erikvold/1137929 Bug 1137930 - It should be possible to cancel sdk/event/core once r=jsantell
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(evold)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•