Closed Bug 1137933 Opened 9 years ago Closed 9 years ago

Don't cache the docshell in WebNavigation in browser-child.js

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 40
Tracking Status
e10s m6+ ---
firefox40 --- fixed

People

(Reporter: mccr8, Assigned: billm)

References

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 file, 1 obsolete file)

When running toolkit/components/addoncompat/ we end up holding onto a docshell for too long.  Bill and I looked at this, and it seems like what is happening is that the _webNavigation field of WebNavigation keeps the docshell alive, even past when we clear the webNavigation field off of the global.  Bill wrote a patch to fix this that just makes us QI it every time we access it, avoiding the leak.
tracking-e10s: --- → ?
Also don't cache the session history, because we only use it in init.

(Bill wrote this patch.)
Attachment #8570736 - Flags: review?(felipc)
Attachment #8570736 - Flags: review?(felipc) → review+
Try run was green.  It looks like this fixes up almost all of the remaining bc and dt DOCSHELL DOMWINDOW leaks, based on Bill's push to Holly.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a761ac6f8bcc
This seems to be making opt builds time out in e10s bc3, in various thumbnails tests.  Very weird.

I think the timeouts are due to this exception being thrown:

09:18:10 WARNING - TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - ReferenceError: executeSoon is not defined at chrome://mochitests/content/browser/toolkit/components/thumbnails/test/head.js:228
backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/d0e70d2cf479

I guess I'll look into these failures on Monday.
Whiteboard: [MemShrink] → [MemShrink:P2]
Attached patch patch v2Splinter Review
The original patch had a bug. There's a pre-existing comment explaining that we need to keep the sessionHistory alive. This patch regressed that. Anyway, this new patch fixes the issue and still avoids leaks.
Attachment #8570736 - Attachment is obsolete: true
Attachment #8585216 - Flags: review?(felipc)
Attachment #8585216 - Attachment is patch: true
Attachment #8585216 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/00e022f7e45e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Depends on: 1150224
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: