1138050 - Jetpack action/toggle buttons + Linux + Firefox 36+: wrong icon sizes on toolbars

Status: RESOLVED WORKSFORME

(Firefox :: Untriaged, defect)

Description

[Aris]

Attachment: australis-ui.xpi

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20150223185154

Steps to reproduce:

This bug only occurs on Linux. Windows and MacOSX are fine!

Firefox 36-39: install a Jetpack add-on like Self Destructing Cookies
https://addons.mozilla.org/en-US/firefox/addon/self-destructing-cookies/
or the Australis ui demo (provided on AMO) and attached here.

Move the button to menubar, bookmarks toolbar or a toolbar provided by third party add-ons.

Navigation toolbar and tabs toolbar are not affected by this issue.


Actual results:

Icon size growth to 32x32 px instead of being max. 18 px.
http://i.imgur.com/gXRXlBK.png


Expected results:

Icon size should no extend 18 px on any toolbar.

Temporal fix
toolbar:not(#nav-bar):not(#TabsToolbar) toolbarbutton[id^="action-button-"] .toolbarbutton-icon,
toolbar:not(#nav-bar):not(#TabsToolbar) toolbarbutton[id^="toggle-button-"] .toolbarbutton-icon {
  max-width:18px !important;
}

Comment 1

[Aris]

Attachment: Screenshot shows buttons on menubar, bookmarks bar and addon bar.

Comment 2

[cb474]

I have this problem in Firefox 36, on Manjaro (Arch) Linux, x86_64.

If I put the icon for self-destructing cookies in the add-on bar, it becomes nearly twice the height of the other icons and the add-on bar height adjusts to this larger size. If I put the icon in the navigation bar, it is constrained to the size of the navigation bar and other icons.

Comment 3

[Liviu Cirdei]

User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID 	20160104030217

This works for me on Nightly 46. I used the Self Destructing Cookies icon, and it renders correctly on menubar, bookmarks toolbar and a toolbar provided by third party add-ons. 

Could you check if it's still reproducing for you on latest Nightly version (currently 46 - https://nightly.mozilla.org/)?

Comment 4

[Aris]

This bug is fixed here too.
The "fix" was part of Firefox 40 changes, if I remember correctly.

Comment 5

[Liviu Cirdei]

Thank you for your response.