1138064 - Timezone change Cancun as of February 1 2015

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[Michael Kohler [:mkohler]]

Cancun has changed its timezone to EST as of February 1 2015, so the offset should be -05:00,-04:00 now.

http://abcnews.go.com/Travel/cancun-change-eastern-standard-time/story?id=28589197

Comment 1

[Michael Kohler [:mkohler]]

Further there will be no daylight saving in 2015.

Comment 2

[Michael Kohler [:mkohler]]

I changed the tz.json file to reflect -05:00,-05:00: https://github.com/MichaelKohler/gaia/commit/b6522bb266e11e97e646454c943e14e5c65fcdcf

When I test it, the |systemTimeChanged.tz| object contains the correct offset here: http://mxr.mozilla.org/gaia/source/shared/js/tz_select.js#214

Nevertheless the time in the top right in the status bar is not changed to the correct time. This works with all other timezones as expected, just not for the changed "Cancun" timezone.

Could somebody point me in the right direction?

Comment 3

[Michael Kohler [:mkohler]]

Attachment: PR

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8609933 [details] [review]
PR

This looks good to me, but right now there are three commits in the pull request. Could you squash them into a single one and re-flag me? You can use git rebase to do so, or if you have trouble with it let me know and I can handle it. Thanks!

Comment 5

[Michael Kohler [:mkohler]]

Comment on attachment 8609933 [details] [review]
PR

Thanks for the review. I have now squashed the commits. This should be good now.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8609933 [details] [review]
PR

This looks good to me. Thank you for tracking it down!

Comment 7

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/7ced08638c33005ebcd55ca23534f1b2b2c959a6