1138084 - Move bookmarks-reader app out of dev_apps folder

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

This app should either be a fixture inside the bookmark folder, or removed entirely. Now that we display bookmarks on the home screen, it's really not needed. If we wanted to though, we could move it to the apps/bookmark/test folder then people could symlink it to the outoftree_apps/ folder for local testing.

Comment 1

[Kevin Grandon :kgrandon]

Cristian - Is the bookmarks reader app still needed now that we display bookmarks in the home screen? I would like to either move this into the bookmark app in the test/ folder, or remove it from the tree entirely. If we do remove it from the tree, we could always create an external repository under mozilla-b2g and host it - we could even add it to the marketplace if there is value.

(Feel free to take this bug if you want)

Comment 2

[Cristian Rodriguez (:crdlc)]

Yes, we can remove this completely, it is not needed anymore. I did this just to have an example for other authors when we implemented the bookmarks datastore

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1138084_remove_bookmarks_reader > mozilla-b2g:master

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8573277 [details] [review]
[gaia] KevinGrandon:bug_1138084_remove_bookmarks_reader > mozilla-b2g:master

R=me based on comment 2.

Comment 5

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 6

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/7a91c16bfa348be8b25e09719178efa051512988