Last Comment Bug 1138093 - Fix in-tree consumers that use non-standard flag argument of String.prototype.{search,match,replace} in calendar/.
: Fix in-tree consumers that use non-standard flag argument of String.prototype...
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All All
-- normal (vote)
: 4.1
Assigned To: Tooru Fujisawa [:arai]
:
:
Mentors:
Depends on:
Blocks: 1108382
  Show dependency treegraph
 
Reported: 2015-02-28 13:56 PST by Tooru Fujisawa [:arai]
Modified: 2015-03-01 08:08 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Do not use non-standard flag argument of String.prototype.replace in calendar/. (15.26 KB, patch)
2015-02-28 16:40 PST, Tooru Fujisawa [:arai]
philipp: review+
Details | Diff | Splinter Review

Description User image Tooru Fujisawa [:arai] 2015-02-28 13:56:47 PST
(same as bug 1131107)

Before fixing bug 1108382, we need to replace all of them with regexp literal, new RegExp(...) or .split().join().
Comment 1 User image Philipp Kewisch [:Fallen] 2015-02-28 14:08:19 PST
Thanks arai! Archaeopteryx, maybe you want to take care of this one?
Comment 2 User image Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) 2015-02-28 14:33:48 PST
Arai has patches.
Comment 3 User image Tooru Fujisawa [:arai] 2015-02-28 16:40:49 PST
Created attachment 8570973 [details] [diff] [review]
Do not use non-standard flag argument of String.prototype.replace in calendar/.

Fixed String.prototype.replace call sites. Used .split().join() if pattern is variable, and used regexp literals for other cases.

at least no regression on try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7a729c78766a
Comment 4 User image Philipp Kewisch [:Fallen] 2015-02-28 23:44:26 PST
Comment on attachment 8570973 [details] [diff] [review]
Do not use non-standard flag argument of String.prototype.replace in calendar/.

Review of attachment 8570973 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=philipp
Comment 5 User image Tooru Fujisawa [:arai] 2015-03-01 07:52:08 PST
Thank you! :D

https://hg.mozilla.org/comm-central/rev/3caaa51155f8

Note You need to log in before you can comment on or make changes to this bug.