Fix in-tree consumers that use non-standard flag argument of String.prototype.{search,match,replace} in calendar/.

RESOLVED FIXED in 4.1

Status

Calendar
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: arai, Assigned: arai)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
(same as bug 1131107)

Before fixing bug 1108382, we need to replace all of them with regexp literal, new RegExp(...) or .split().join().
Thanks arai! Archaeopteryx, maybe you want to take care of this one?
Flags: needinfo?(archaeopteryx)
(Assignee)

Updated

2 years ago
Blocks: 1108382
Arai has patches.
Flags: needinfo?(archaeopteryx)
(Assignee)

Comment 3

2 years ago
Created attachment 8570973 [details] [diff] [review]
Do not use non-standard flag argument of String.prototype.replace in calendar/.

Fixed String.prototype.replace call sites. Used .split().join() if pattern is variable, and used regexp literals for other cases.

at least no regression on try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7a729c78766a
Attachment #8570973 - Flags: review?(philipp)
Comment on attachment 8570973 [details] [diff] [review]
Do not use non-standard flag argument of String.prototype.replace in calendar/.

Review of attachment 8570973 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=philipp
Attachment #8570973 - Flags: review?(philipp) → review+
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
(Assignee)

Comment 5

2 years ago
Thank you! :D

https://hg.mozilla.org/comm-central/rev/3caaa51155f8
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.1
You need to log in before you can comment on or make changes to this bug.