1138172 - Three strings about SMTP errors tell user to change connection/password/authentication method in Account settings > Server settings, but should be in Outgoing server (SMTP)

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Three strings about SMTP errors tell user to change connection/password/authentication method in Account settings > Server settings, but should be in Outgoing server (SMTP)

smtpAuthChangeEncryptToPlainNoSsl=The Outgoing server (SMTP) %S does not seem to support encrypted passwords. If you just set up the account, try changing the 'Authentication method' in 'Account Settings | Server settings' to 'Password, transmitted insecurely'. If it used to work but now doesn't, you may be susceptible to getting your password stolen.
smtpAuthChangeEncryptToPlainSsl=The Outgoing server (SMTP) %S does not seem to support encrypted passwords. If you just set up the account, try changing the 'Authentication method' in 'Account settings | Server settings' to 'Normal password'.
smtpAuthChangePlainToEncrypt=The Outgoing server (SMTP) %S does not allow plaintext passwords. Please try changing the 'Authentication method' in 'Account Settings | Server settings' to 'Encrypted password'.

Comment 1

[[e-mail]]

And I called it out in bug 952493 comment #45 too...

Comment 2

[:aceman]

Well, considering the comment:
>>+# LOCALIZATION NOTE (smtpAuthChangeEncryptToPlainSsl): %S is the server hostname
>>+smtpAuthChangeEncryptToPlainSsl=The SMTP server %S does not seem to support encrypted passwords. If you just >+# LOCALIZATION NOTE (smtpAuthChangePlainToEncrypt): %S is the server hostname
>>+smtpAuthChangePlainToEncrypt=The SMTP server %S does not allow plaintext passwords. Please try changing the 'Authentication method' in 'Account Settings | Server settings' to 'Encrypted password'.
>>+# LOCALIZATION NOTE (smtpAuthFailure): %S is the server hostname
>>+smtpAuthFailure=Unable to authenticate to SMTP server %S. Please check the password, and verify the 'Authentication method' in 'Account Settings | Outgoing server (SMTP)'.

>Huh, shouldn't these all say Outgoing server (SMTP)?

You see Suyash changed the string, but he changed the leading "SMTP server" to "Outgoing server (SMTP)", going by the "SMTP" keyword.
The comment was probably too short or ambiguous to understand you mean to rewrite the whole path to Account manager pane instead :)

Now that seems to be clear, I'll do it.

Comment 3

[:aceman]

Attachment: patch [checked in]

Comment 4

[[e-mail]]

(In reply to aceman from comment #2)
> The comment was probably too short or ambiguous to understand you mean to
> rewrite the whole path to Account manager pane instead :)

Oops. Sorry, Suyash.

Comment 5

[[e-mail]]

Bah, these have reached Aurora and 11 localisers have already translated them.

Comment 6

[[e-mail]]

Comment on attachment 8571529 [details] [diff] [review]
patch [checked in]

(Huh, when did Thunderbird drop the "please" from their two strings?)

Comment 7

[Kent James (:rkent)]

Is this something that we will need for TB 38?

Comment 8

[:aceman]

If you r+ it for /mail it could go into TB38. But it is no regression (the bug was in the strings even before Suyash touched them recently), just a bug fix. So you can decide.

Comment 9

[Kent James (:rkent)]

If this was not a regression, then we should not try to push it into TB 38.

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 8571529 [details] [diff] [review]
patch [checked in]

Review of attachment 8571529 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 11

[:aceman]

Thanks.

Comment 12

[Philip Chee]

Comment on attachment 8571529 [details] [diff] [review]
patch [checked in]

a=me for SeaMonkey CLOSED TREE

Comment 13

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/30f695264e00

Comment 14

[Vlado Valastiak [:wladow] @ Mozilla.sk]

Nit: the asociated loc notes need to be adjusted as well, the entity names do not match with actual entities now.

Comment 15

[:aceman]

Attachment: patch fix notes

Argh, thanks for noticing.

Comment 16

[Philip Chee]

Comment on attachment 8574859 [details] [diff] [review]
patch fix notes

a=me for SeaMonkey CLOSED TREE

Comment 17

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Pushed localization comment fixes as https://hg.mozilla.org/comm-central/rev/ad7600eae938