Get rid of the XMPP account buddy contactDisplayName

NEW
Unassigned

Status

Chat Core
XMPP
3 years ago
a year ago

People

(Reporter: aleth, Unassigned)

Tracking

trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8571064 [details] [diff] [review]
displayname.diff

XMPP account buddies have a strange contactDisplayName property which prefers the contact display name to the account buddy display name.

It's not clear to me why this is desirable or needed, so I'm r?ing a removal patch that simplifies things.
Attachment #8571064 - Flags: review?(florian)
Comment on attachment 8571064 [details] [diff] [review]
displayname.diff

This contactDisplayName thing was obviously ugly and we hoped to change it 'soon'. From what I remember, without that hack, if you set an alias for a contact in your contact list, it won't be displayed for conversation messages.

Could you please verify that your patch isn't breaking this?

The good news is that we now have an imMessage abstraction above the prplMessage, which is exactly what's needed to implement a clean prpl-independent handling of contact aliases :-).
Attachment #8571064 - Flags: review?(florian) → review-
(Reporter)

Comment 2

3 years ago
(In reply to Florian Quèze [:florian] [:flo] (Away until March 11) from comment #1)
> This contactDisplayName thing was obviously ugly and we hoped to change it
> 'soon'. From what I remember, without that hack, if you set an alias for a
> contact in your contact list, it won't be displayed for conversation
> messages.
> 
> Could you please verify that your patch isn't breaking this?

I'm not sure what the expected behaviour is here. If I
1) rename a contact in the contact list (to give it a local alias)
2) open a conversation and get an incoming message from the contact
then the local alias is displayed in messages.

However, this may simply be because on 1) we propagate the new contact name to the server:

<iq type="set" id="efe3c72c-7818-ee42-aad2-fc5065bf4d72"><query xmlns="jabber:iq:roster"><item xmlns="jabber:iq:roster" jid="aleth@..." subscription="both" name="io-renamed-contact"><group xmlns="jabber:iq:roster">Blue</group></item></query></iq>

and the account buddy display name changes too.

Therefore I'm not sure what needs to be tested here - how do you end up in a problematic situation?

(For comparison, in IRC, if I rename a contact, messages in PMs still appear with the sender = the actual nick, not the contact display name. Which is not the XMPP behaviour before or after this patch.)
(In reply to aleth [:aleth] from comment #2)
> we propagate the new contact name to the server:
> 
> <iq type="set" id="efe3c72c-7818-ee42-aad2-fc5065bf4d72"><query
> xmlns="jabber:iq:roster"><item xmlns="jabber:iq:roster" jid="aleth@..."
> subscription="both" name="io-renamed-contact"><group
> xmlns="jabber:iq:roster">Blue</group></item></query></iq>
> 
> and the account buddy display name changes too.

This won't work for Facebook chat where the 'server' will happily ignore the alias we send.

> (For comparison, in IRC, if I rename a contact, messages in PMs still appear
> with the sender = the actual nick, not the contact display name. Which is
> not the XMPP behaviour before or after this patch.)

I don't think that's the intended behavior. It probably hasn't bothered anybody because on IRC the nicks tend to be short, whereas on XMPP if there's no specified display name, we end up with the full JID which is looong.
(Reporter)

Updated

2 years ago
Status: ASSIGNED → NEW
(Reporter)

Updated

2 years ago
Assignee: aleth → nobody
You need to log in before you can comment on or make changes to this bug.