1138268 - [Search][Nexus 5] search icon covers over suggestion on Nexus 5

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Hermes Cheng (inactive after July 27, 2015)]

Attachment: Flame and Nexus 5 screenshot

When I use search app on Nexus5, each suggestion is covered over by search icon.

Comment 1

[Hermes Cheng (inactive after July 27, 2015)]

In the attachment 8571146 [details], the left device is flame and the right device is Nexus 5.

Comment 2

[Kevin Grandon :kgrandon]

Requesting blocking as this could likely impact devices launched with 2.2 in the future.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1138268_icon_sizing > mozilla-b2g:master

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8571148 [details] [review]
[gaia] KevinGrandon:bug_1138268_icon_sizing > mozilla-b2g:master

Dale - could I get a quick review stamp here? Thanks!

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 8571148 [details] [review]
[gaia] KevinGrandon:bug_1138268_icon_sizing > mozilla-b2g:master

Looks good cheers

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/8dcb45cdc14bad2abe23eefce51b5a77655c5ec5

Comment 8

[Hermes Cheng (inactive after July 27, 2015)]

Kevin, since this bug blocks 2.2, could you please uplift to v2.2?

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8571148 [details] [review]
[gaia] KevinGrandon:bug_1138268_icon_sizing > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Poor UX on higher resolution devices (flame and above).
[Testing completed]: Manual testing, css only change.
[Risk to taking this patch] (and alternatives if risky): Low risk, small css changes.
[String changes made]: None.

Comment 10

[Shine(Leave from Mozilla)]

Attachment: Screenshot

This problem is verified pass on latest build of Flame 3.0
STR:
1.Tap the Rocket bar on Homescreen.
2.Input keyword to search it.
** The suggestion is not covered over by search icon.
See attachment: Screenshot.png
Rate: 0/5

Flame 3.0 build:
Build ID               20150304010324
Gaia Revision          3fc0ac309f5fb0c1fe82c12223b955a4efce27e6
Gaia Date              2015-03-03 21:58:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c5b90c003be8
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150304.041952
Firmware Date          Wed Mar  4 04:20:03 EST 2015
Bootloader             L1TC000118D0

Comment 11

[Hermes Cheng (inactive after July 27, 2015)]

Shine, could you verify this bug on Nexus 5 for master branch?

Comment 12

[Shine(Leave from Mozilla)]

Attachment: screenshot

Hi Hermes,
This bug is verified pass on latest build of Nexus 5 master build.
See attachment: N5_screenshot.png
Rate: 0/5

Nexus5 master build:
Build ID               20150304160447
Gaia Revision          eff3321ab4e65da3f906688ebb55ddf1e93d9452
Gaia Date              2015-03-04 17:42:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/56492f7244a9
Gecko Version          39.0a1
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150304.192817
Firmware Date          Wed Mar  4 19:28:34 EST 2015
Bootloader             HHZ12d

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/8d86be7fbc31dc6eb12fa8ff54b00865b12d8b96

Comment 14

[Hermes Cheng (inactive after July 27, 2015)]

Verify on Nexus 5 2.2 build

* env info:
Build ID               20150305162505
Gaia Revision          eb86137e247224e86d17ed1a0a133b2a318dce3c
Gaia Date              2015-03-05 16:51:07
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e9d29a3b94e5
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150305.201134
Firmware Date          Thu Mar  5 20:11:51 EST 2015
Bootloader             HHZ12d