1138401 - There's a spurious \n in the mailnews/suite version of smtpServerError

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

One of the strings modified in bug 952493 is wrong I think...
smtpServerError ends with :  %s\n.
I think the \n will cause the trailing period to appear on an empty line, but I'm not quite sure about it (can't test because I'm on Windows)

Comment 1

[:aceman]

Yeah, the TB version of the strings doesn't have the \n.
Will you fix it or should we?

Comment 2

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: bug113401_mailnews_smtpServerError_typo.patch

Comment 3

[Onno Ekker [:nONoNonO UTC+1]]

Hmz... typo in the file name of the patch, should be bug 1138401 instead of 113401 :-/

Comment 4

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: bug1138401_mailnews_smtpServerError_typo.patch

Comment 5

[Suyash Agarwal (:sshagarwal)]

Comment on attachment 8571803 [details] [diff] [review]
bug1138401_mailnews_smtpServerError_typo.patch

Review of attachment 8571803 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/locales/en-US/chrome/mailnews/compose/composeMsgs.properties
@@ +33,1 @@
>  unableToSendLater=Sorry, we were unable to save your message for sending later.

I am sorry for making so many typos. 
Looks good to me.
Can we also remove this extra space between the %s string and the message? 

Thanks.

Comment 6

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: bug1138401_change_double_space_to_single.patch

I've "s/  %s/ %s/"-ed in both mail and mailnews composeMsgs.properties, but there are more double spaces in the messages, especially following a period or colon. I see this more in texts, to better show where a new sentence starts and I don't know *how* the error messages are shown. if the strings are displayed as html, all white space will be shown as a single space anyway...

Comment 7

[:aceman]

NO, they are not shown in HTML mode. So the double spaces will be visible. However it may be intentional formatting. I wouldn't try to decide about that in this bug. We can make a new one for fixing the double spacing globally.

Comment 8

[:aceman]

Comment on attachment 8571861 [details] [diff] [review]
bug1138401_change_double_space_to_single.patch

I would propose to move this patch to a new  bug, where it can be decided why the double spaces were there and if they are still needed. This issue does not relate to the bug here.

Comment 9

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/87e3cb843f65

Comment 10

[Philip Chee]

(In reply to :aceman from comment #8)
> Comment on attachment 8571861 [details] [diff] [review]
> bug1138401_change_double_space_to_single.patch
> 
> I would propose to move this patch to a new  bug, where it can be decided
> why the double spaces were there and if they are still needed. This issue
> does not relate to the bug here.
Did anyone file a new bug for this. Note both Thunderbird and SeaMonkey versions of this file has double spaces.

Comment 11

[:aceman]

Hi, I wouldn't ask the author to file the bug if I knew it was already filed. I see no further progress since I asked that.

Comment 12

[Magnus Melin [:mkmelin]]

As I understand it the double spaces is an old form of making parts more clearly separated. I don't think they are needed per se, but also do little harm.