1138545 - Page-worker does not support regex

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

See:

1. https://developer.mozilla.org/en-US/Add-ons/SDK/High-Level_APIs/page-worker#Page%28options%29 - docs say we do support regex, but

2. https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/page-worker.js#L55 we only support strings and arrays

You can however specify an *array* of regex objects, this is the workaround:

page.Page({
  include: [/http[s]{0,1}:\/\/(www\.)*google\.[\w]+/]
  // ...
});

So between the docs and the support of regex in arrays, it feels like the intent was to support regex.

See this stackoverflow question: http://stackoverflow.com/questions/28813605/firefox-addon-sdk-page-worker-regex

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I've opened https://github.com/mozilla/addon-sdk/pull/1882

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1883

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/bf0ae49996bfabbe942df471311863867958049e
bug 1138545 - shouldbe able to pass in a bare regex to page-worker

https://github.com/mozilla/addon-sdk/commit/cbb9d34dd2c36f5e1634aafb1069001d5adebea2
Merge pull request #1883 from canuckistani/bug-1138545-pageworker-regex

Bug 1138545 - should be able to pass in a bare regex to page-worker r=erikvold