Update remaining callsites to use newChannel2 in browser/metro

RESOLVED FIXED in Firefox 39

Status

()

Core
DOM: Security
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Assignee: nobody → mozilla
Blocks: 1087726
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8571542 [details] [diff] [review]
bug_1138645_browser_metro.patch
(Assignee)

Comment 2

3 years ago
Mark, in Bug 1038756 we started attaching a loadInfo to every channel whenever the channel gets created through NS_NewChannel in nsNetUtil.h. Now we are expanding the loadInfo attachment to also include channels that get created within JS to ultimately end up having a loadInfo on every channel.

Please find a description of all the required arguments to create a channel here [1] or alternatively here [2].

Please keep in mind that all the arguments that are passed to newChannel become security critical once we move security checks into AsyncOpen(). We are not experts within browser/metro code, hence I was wondering if you review that patch or delegate it to someone who knows that code really well. Thanks!

[1] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsNetUtil.h#191
[2] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsIIOService.idl#69
Flags: needinfo?(mark.finkle)
Comment on attachment 8571542 [details] [diff] [review]
bug_1138645_browser_metro.patch

This patch looks pretty sane to me. Also, the browser/metro code is likely going to be removed very soon, so we should be able to free people from needing to keep the code updated, without a product to build/verify.
Flags: needinfo?(mark.finkle)
Attachment #8571542 - Flags: review+

Comment 5

3 years ago
https://hg.mozilla.org/mozilla-central/rev/c3fa9af19578
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.