Closed Bug 1138731 Opened 9 years ago Closed 9 years ago

Build failure on Beta in non-unified mode

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Version:
37 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox37 fixed, firefox38 fixed, firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: jya, Assigned: jya)

Details

Attachments

(1 file)

Fix non-unified compilation in beta
823 bytes, patch
smichaud
: review+
Details | Diff | Splinter Review 
widget/cocoa/TextInputHandler.mm doesn't compile on beta with non-unified build
fix non-unified build.
Attachment #8571667 - Flags: review?(ryanvm)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Attachment #8571667 - Flags: review?(ryanvm) → review?(smichaud)
Comment on attachment 8571667 [details] [diff] [review]
Fix non-unified compilation in beta

Nice catch.
Attachment #8571667 - Flags: review?(smichaud) → review+
Comment on attachment 8571667 [details] [diff] [review]
Fix non-unified compilation in beta

Approval Request Comment
[Feature/regressing bug #]: NA
[User impact if declined]: Can't compile beta on mac with unified build disabled.
[Describe test coverage new/current, TreeHerder]: None.
[Risks and why]: None, only adding missing header.
[String/UUID change made/needed]: None
Attachment #8571667 - Flags: approval-mozilla-beta?
As per IRC discussion...
Flags: needinfo?(ryanvm)
Comment on attachment 8571667 [details] [diff] [review]
Fix non-unified compilation in beta

I'm just going to land this a=bustage
Flags: needinfo?(ryanvm)
Attachment #8571667 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/839e567bda26
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 39 → mozilla39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: