1138735 - Fallback to software vsync if CVDisplayLink fails to initialize

Status: RESOLVED FIXED

(Core :: Graphics, defect, P2)

Description

[Mason Chang [Inactive] [:mchang]]

Fallback to software vsync on OS X if CVDisplayLink has an error initializing.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Fallback to software vsync if hardware vsync is unavailable on OS X

Just a check to make sure we can enable hardware vsync. Otherwise default back to software vsync.

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8571669 [details] [diff] [review]
Fallback to software vsync if hardware vsync is unavailable on OS X

Review of attachment 8571669 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPlatformMac.cpp
@@ +555,5 @@
> +    NS_WARNING("OS X Vsync source not enabled. Falling back to software vsync.\n");
> +    return gfxPlatform::CreateHardwareVsyncSource();
> +  }
> +
> +  primaryDisplay.DisableVsync();

What's this for? If it's needed, why weren't we doing this before?

Comment 3

[Mason Chang [Inactive] [:mchang]]

(In reply to Markus Stange [:mstange] from comment #2)
> Comment on attachment 8571669 [details] [diff] [review]
> Fallback to software vsync if hardware vsync is unavailable on OS X
> 
> Review of attachment 8571669 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/thebes/gfxPlatformMac.cpp
> @@ +555,5 @@
> > +    NS_WARNING("OS X Vsync source not enabled. Falling back to software vsync.\n");
> > +    return gfxPlatform::CreateHardwareVsyncSource();
> > +  }
> > +
> > +  primaryDisplay.DisableVsync();
> 
> What's this for? If it's needed, why weren't we doing this before?

It's just to make sure that we can use hardware vsync. If we can't for whatever reason, we can still fallback to software vsync. We weren't doing it before because I write bugs :). Sorry! But we do this on b2g as well and Windows [1].

[1] https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxWindowsPlatform.cpp?from=gfxWindowsPlatform.cpp#2116

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8571669 [details] [diff] [review]
Fallback to software vsync if hardware vsync is unavailable on OS X

Makes sense, thanks.

Comment 5

[Mason Chang [Inactive] [:mchang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57e351862f31

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/57e351862f31