Closed Bug 1138771 Opened 5 years ago Closed 5 years ago

[EME] Crash in assertion in GMPVideoDecoderParent::Shutdown()

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Sometimes we can call GMPVideoDecoderParent::Shutdown() after mPlugin has been shutdown, and the assertion there that mPlugin->GMPThread() == NS_GetCurrentThread() crashes as mPlugin is null.

I found a similar crash in bug 1136986 but unfortunately I missed this case.
Summary: [EME] Fatal assertion in GMPVideoDecoderParent::Shutdown() → [EME] Crash in assertion in GMPVideoDecoderParent::Shutdown()
Attached patch PatchSplinter Review
Obvious null check...
Attachment #8571723 - Flags: review?(edwin)
https://hg.mozilla.org/mozilla-central/rev/eec321940021
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment on attachment 8571723 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Crashes in assertions in debug builds, makes the sherifss unhappy.
[Describe test coverage new/current, TreeHerder]: This may reduce crashes in EME tests on TreeHerder.
[Risks and why]: Low, this should make us crash less.
[String/UUID change made/needed]: None.
Attachment #8571723 - Flags: approval-mozilla-beta?
Attachment #8571723 - Flags: approval-mozilla-aurora?
Comment on attachment 8571723 [details] [diff] [review]
Patch

OK. I like to have happy sheriffs. Beta+ Aurora+
Attachment #8571723 - Flags: approval-mozilla-beta?
Attachment #8571723 - Flags: approval-mozilla-beta+
Attachment #8571723 - Flags: approval-mozilla-aurora?
Attachment #8571723 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.