Closed Bug 1138771 Opened 5 years ago Closed 5 years ago
[EME] Crash in assertion in GMPVideo
Sometimes we can call GMPVideoDecoderParent::Shutdown() after mPlugin has been shutdown, and the assertion there that mPlugin->GMPThread() == NS_GetCurrentThread() crashes as mPlugin is null. I found a similar crash in bug 1136986 but unfortunately I missed this case.
Summary: [EME] Fatal assertion in GMPVideoDecoderParent::Shutdown() → [EME] Crash in assertion in GMPVideoDecoderParent::Shutdown()
Obvious null check...
Attachment #8571723 - Flags: review?(edwin)
Attachment #8571723 - Flags: review?(edwin) → review+
Comment on attachment 8571723 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: EME [User impact if declined]: Crashes in assertions in debug builds, makes the sherifss unhappy. [Describe test coverage new/current, TreeHerder]: This may reduce crashes in EME tests on TreeHerder. [Risks and why]: Low, this should make us crash less. [String/UUID change made/needed]: None.
Comment on attachment 8571723 [details] [diff] [review] Patch OK. I like to have happy sheriffs. Beta+ Aurora+
You need to log in before you can comment on or make changes to this bug.